Bug 458838

Summary:	Low contrast for checkbox when drawn over selected list item
Product:	[Plasma] Breeze	Reporter:	D3XT3R <tresdexter>
Component:	QStyle	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	CONFIRMED ---
Severity:	minor	CC:	nate, noahadvs, tantalising007, uhhadd
Priority:	NOR	Keywords:	usability
Version First Reported In:	5.25.5
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Bad checkbox contrast Bad checkbox contrast - hovered

Description D3XT3R 2022-09-07 14:07:49 UTC

I have no idea which component I should assign this report to, I hope it moves it to the most suitable location.

When selecting an update listed in Discover, using the Dark Breeze theme, the checkbox has a low contrast.

Low contrast in the two situations below:

https://imgur.com/a/LSwjY9s

Comment 1 Nate Graham 2022-09-07 16:00:27 UTC

This is a visual incompatibility between the Breeze-styled checkbox, and the list items in Discover. We have a few options for how to fix it:
1. Change Breeze to improve background.border contrast when a checkbox is drawn on top of a selected list item using the current style
2. Change Discover to use a custom selection style for these list items that incorporates a lighter background color 
3. Change Kirigami to use a custom selection style for all list items that incorporates a lighter background color (which is something we've wanted to do anyway) and then port Discover to use it

Given that we can't implement #2 or #3 for QtWidgets apps, #1 is our best bet. Moving to Breeze.

In the future please attach images, rather than pasting a link. The link can die.

Comment 2 Nate Graham 2022-09-07 16:01:53 UTC

Created attachment 151890 [details]
Bad checkbox contrast

Comment 3 Nate Graham 2022-09-07 16:02:07 UTC

Created attachment 151891 [details]
Bad checkbox contrast - hovered