Bug 458608

Summary: Defaults button does not reset all settings
Product: [Applications] systemsettings Reporter: Nicolas Fella <nicolas.fella>
Component: kcm_tabletAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: aleixpol, nate
Priority: NOR    
Version First Reported In: master   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/commit/8f5f06fcaf5b77a804308c3c7dc4b16ff80be153 Version Fixed/Implemented In:
Sentry Crash Report:

Description Nicolas Fella 2022-09-01 18:38:24 UTC 
STEPS TO REPRODUCE
1. Change some setting, e.g. the tablet area to a custom size 
2. Click 'Defaults'

OBSERVED RESULT
Area setting stays the same

EXPECTED RESULT
Area setting is reset to 'Fit to output'

SOFTWARE/OS VERSIONS
KDE Plasma Version: master
KDE Frameworks Version: master
Qt Version: 5.15.5-kde

ADDITIONAL INFORMATION
Comment 1 Bug Janitor Service 2022-09-26 22:36:56 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1179
Comment 2 Aleix Pol 2022-11-08 09:12:20 UTC 
Git commit ce2e096c4fbba39969ef2ea84aafe18893cedab2 by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 08/11/2022 at 09:08.
Pushed by apol into branch 'master'.

tablet: Fix the reset button for the outputs view

M  +3    -0    kcms/tablet/inputdevice.h
M  +4    -4    kcms/tablet/kcmtablet.cpp
M  +1    -1    kcms/tablet/kcmtablet.h
M  +1    -1    kcms/tablet/package/contents/ui/RebindButtons.qml
M  +15   -4    kcms/tablet/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/ce2e096c4fbba39969ef2ea84aafe18893cedab2
Comment 3 Aleix Pol 2022-11-08 11:16:08 UTC 
Git commit 8f5f06fcaf5b77a804308c3c7dc4b16ff80be153 by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 08/11/2022 at 11:16.
Pushed by apol into branch 'Plasma/5.26'.

tablet: Fix the reset button for the outputs view


(cherry picked from commit ce2e096c4fbba39969ef2ea84aafe18893cedab2)

M  +3    -0    kcms/tablet/inputdevice.h
M  +4    -4    kcms/tablet/kcmtablet.cpp
M  +1    -1    kcms/tablet/kcmtablet.h
M  +1    -1    kcms/tablet/package/contents/ui/RebindButtons.qml
M  +15   -4    kcms/tablet/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/8f5f06fcaf5b77a804308c3c7dc4b16ff80be153