| Summary: | Konqueror doesn't use/support any KIO addons anymore | ||
|---|---|---|---|
| Product: | [Applications] konqueror | Reporter: | kde |
| Component: | general | Assignee: | Konqueror Developers <konq-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | asturm, stefano.crocco |
| Priority: | NOR | ||
| Version: | 22.08.0 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/network/konqueror/commit/28760cd6b9ab59f659e2c8222963c2c99a7e092a | Version Fixed In: | |
|
Description
kde
2022-08-29 13:01:17 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/konqueror/-/merge_requests/136 Dear bug reporter, would you please test both commits from the linked MR? You can easily do that by following the instructions in https://wiki.gentoo.org/wiki//etc/portage/patches The file 136.patch (https://invent.kde.org/network/konqueror/-/merge_requests/136.patch) did not apply to version 22.08.0 and 22.08.1 provided from gentoo. So using latest master of konqueror, applied the patch and build. Starting konqueror in build directory, but same result: every times entering a non-http address the open-with-dialog comes up and console shows: QObject::connect(KJob, UrlLoader): invalid nullptr parameter That's because the merge request is still pending, not in master. (In reply to Andreas Sturmlechner from comment #4) > That's because the merge request is still pending, not in master. Oh sorry, should read more carefully. A possibly relevant merge request was started @ https://invent.kde.org/network/konqueror/-/merge_requests/148 Git commit 253b1f25ff7bd8ba8deaee3f419270caaec9493c by Stefano Crocco. Committed on 09/11/2022 at 13:34. Pushed by stefanocrocco into branch 'master'. Fix UrlLoader behavior in special cases This fixes two issues: - a bug causing URLs with schemes like ftp to always be opened in external applications. This happens because for these protocols KIO::OpenUrlJob doesn't emit the mimeTypeFound signal. To fix this, we explicitly use KIO::MimeTypeFinderJob to determine the mimetype of the URL - a bug causing an attempt to open local URLs corresponding to nonexisting paths using the smb ioslave. This is fixed by explicitly checking whether the file exists and assigning it an "inode/directory" if it doesn't exist. This way, the URL is opened by whatever part/application the user chose to display directories (of course, that part or application will then fail to open the path). M +67 -40 src/urlloader.cpp M +7 -4 src/urlloader.h https://invent.kde.org/network/konqueror/commit/253b1f25ff7bd8ba8deaee3f419270caaec9493c Git commit 28760cd6b9ab59f659e2c8222963c2c99a7e092a by Stefano Crocco. Committed on 09/11/2022 at 13:56. Pushed by stefanocrocco into branch 'release/22.12'. Fix UrlLoader behavior in special cases This fixes two issues: - a bug causing URLs with schemes like ftp to always be opened in external applications. This happens because for these protocols KIO::OpenUrlJob doesn't emit the mimeTypeFound signal. To fix this, we explicitly use KIO::MimeTypeFinderJob to determine the mimetype of the URL - a bug causing an attempt to open local URLs corresponding to nonexisting paths using the smb ioslave. This is fixed by explicitly checking whether the file exists and assigning it an "inode/directory" if it doesn't exist. This way, the URL is opened by whatever part/application the user chose to display directories (of course, that part or application will then fail to open the path). (cherry picked from commit 253b1f25ff7bd8ba8deaee3f419270caaec9493c) M +67 -40 src/urlloader.cpp M +7 -4 src/urlloader.h https://invent.kde.org/network/konqueror/commit/28760cd6b9ab59f659e2c8222963c2c99a7e092a |