Bug 458335

Summary: Dialog window with incoherent labels on the buttons (Save changes before closing)
Product: [Applications] okular Reporter: M3tacat <s>
Component: generalAssignee: Okular developers <okular-devel>
Status: RESOLVED FIXED    
Severity: normal CC: aacid
Priority: NOR    
Version: 22.08.0   
Target Milestone: ---   
Platform: Flatpak   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Step 4 dialog window

Description M3tacat 2022-08-26 09:32:24 UTC
Created attachment 151608 [details]
Step 4 dialog window

SUMMARY
When you close a PDF file without saving, the dialog window asks you if you want to save or to abandon changes. But the answers are "Yes" and "No".

STEPS TO REPRODUCE
1. Open a PDF file in Okular
2. Make some highlighting
3. Close the PDF file
4. Okular asks you if you would like to save or abandon changes : click on the cross to close the dialog window
5. Try again to close the PDF file
6. Now you get the exact same dialog window, but with coherent buttons

OBSERVED RESULT
At step 4, the question is to choose between Save and Abandon, but the buttons you can click are "Yes" and "No". At least in French : see attachment.
At step 6, the question is exactly the same but this time you can choose between saving or abandoning. 

EXPECTED RESULT
- Step 4 and step 6 bring the same dialog window, with the same buttons
- Those buttons should never be "Yes" and "No" since the question is a choice between two named options

SOFTWARE/OS VERSIONS
Linux/GNOME : Ubuntu 22.04.1 LTS, GNOME 42.2
Through Flatpak (flathub)

ADDITIONAL INFORMATION
Newbie here with good intentions but no Linux experience and no dev competences... please be indulgent if I'm not doing this the right way :-)
Comment 1 Albert Astals Cid 2022-08-26 16:50:19 UTC
it's an integration bug with GTK desktops, works fine on plasma.

I can reproduce it with
  XDG_CURRENT_DESKTOP=X-Cinnamon okular 
for example.

Needs investigation which part of the stack is broken, most likely not Okular.
Comment 2 Bug Janitor Service 2022-08-26 18:30:09 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kwidgetsaddons/-/merge_requests/147
Comment 3 Albert Astals Cid 2022-08-28 21:24:59 UTC
Git commit f3947ecf9c714f40fc1c59cb08745efb6be1bf23 by Albert Astals Cid.
Committed on 26/08/2022 at 18:29.
Pushed by aacid into branch 'master'.

Fix KMessageBoxes buttons not having the contents they should the first time

M  +20   -0    src/kmessagebox.cpp
M  +5    -0    src/kmessagebox_p.cpp
M  +2    -0    src/kmessagebox_p.h

https://invent.kde.org/frameworks/kwidgetsaddons/commit/f3947ecf9c714f40fc1c59cb08745efb6be1bf23