Bug 458273

Summary: Showing both version and branch for Flatpaks is confusing
Product: [Applications] Discover Reporter: Nate Graham <nate>
Component: Flatpak BackendAssignee: Plasma Bugs List <plasma-bugs>
Severity: normal CC: aleixpol, jgrulich, travier
Priority: NOR Keywords: usability
Version: master   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 5.26
Attachments: Runtime with two version numbers?

Description Nate Graham 2022-08-24 21:17:28 UTC
Created attachment 151565 [details]
Runtime with two version numbers?

Sometimes the branch is a number, so it looks in Discover like the app/runtime has two version numbers! This is quite confusing.

Sometimes the branch is the word "stable" which is misleading since it implies to the user a level of stability higher than other apps with branches that don't use this naming convention

On the other hand, some apps/runtimes specify no version, so in this case unfortunately we have to show the branch name.

I would recommend that we always show the version number if it's present, and if not, we show the branch name. We shouldn't show both. Hopefully there is no app/runtime that has no version number and its branch name is a word rather than a number.
Comment 1 Bug Janitor Service 2022-08-24 21:41:26 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/356
Comment 2 Nate Graham 2022-08-25 14:54:35 UTC
Git commit ea11c5ace1605108379e55b33c66e9f7b2c6e5c4 by Nate Graham.
Committed on 25/08/2022 at 14:46.
Pushed by ngraham into branch 'master'.

Flatpak: Never show both version number and branch name in one UI string

It can be terribly confusing since many apps and runtimes use branch
names that are in the form of a number. So to the user, it looks like
the app has two version numbers which doesn't make sense.

Instead, always show the version number if it's available. If not, only
show the branch name and hopfully it's in the form of a version number
so it looks like a version number to the user.
FIXED-IN: 5.26

M  +5    -14   libdiscover/backends/FlatpakBackend/FlatpakResource.cpp