Bug 458249

Summary:	Overlay sheet close button should match the location of window controls
Product:	[Frameworks and Libraries] frameworks-kirigami	Reporter:	Jack Hill <jackhill3103>
Component:	general	Assignee:	kdelibs bugs <kdelibs-bugs-null>
Status:	CONFIRMED ---
Severity:	wishlist	CC:	nate, notmart
Priority:	NOR
Version First Reported In:	5.97.0
Target Milestone:	Not decided
Platform:	openSUSE
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=431165
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Jack Hill 2022-08-24 12:54:02 UTC

SUMMARY
I have my window controls set so that the close button is on the left-hand side of the title bar. Kirigami overlay sheets do not match this behaviour.

STEPS TO REPRODUCE
1. Move the "Close" button to the left-hand side of the title bar in System Settings -> Appearance -> Window Decorations -> Titlebar Buttons
2. Open Discover
3. Click "Installed" and then click on any of your installed apps
4. Click "Write a Review"

OBSERVED RESULT
The close button for this overlay sheet is on the right, which does not match the location of the window controls

EXPECTED RESULT
The close button should be on the left

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20220822
KDE Plasma Version: 5.25.4
KDE Frameworks Version: 5.97.0
Qt Version: 5.15.5
Kernel Version: 5.19.2-1-default (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION

Comment 1 Nate Graham 2022-08-25 13:32:57 UTC

Yeah, good idea.