| Summary: | ScrollablePage change in 5.97.0 breaks flickable use in Calamares | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | demm |
| Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | nate, notmart, rinigus.git |
| Priority: | VHI | Keywords: | regression |
| Version First Reported In: | 5.97.0 | ||
| Target Milestone: | Not decided | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/kirigami/commit/27b2a4fbbdb919a54e9a825840f9e9200eaabf74 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
demm
2022-08-20 12:39:01 UTC
Same bug has hit Pure Maps. This does not seem to work: $ QT_IM_MODULE=qtvirtualkeyboard qmlscene usersq.qml qt.qpa.wayland: qtvirtualkeyboard currently is not supported at client-side, use QT_IM_MODULE=qtvirtualkeyboard at compositor-side. file:///home/nate/Desktop/UserInput.qml:41 Cannot set properties on flickable as it is null "There are still \"1\" items in the process of being created at engine destruction." Can you fix the reproducible test case? Thanks! (In reply to Nate Graham from comment #2) > This does not seem to work: > > $ QT_IM_MODULE=qtvirtualkeyboard qmlscene usersq.qml > qt.qpa.wayland: qtvirtualkeyboard currently is not supported at client-side, > use QT_IM_MODULE=qtvirtualkeyboard at compositor-side. > file:///home/nate/Desktop/UserInput.qml:41 Cannot set properties on > flickable as it is null > > "There are still \"1\" items in the process of being created at engine > destruction." > > > Can you fix the reproducible test case? Thanks! That is the issue. Run it with kirigami 5.96 > no error, just works. Output above is when run with 5.97. Are you saying that this error:
> file:///home/nate/Desktop/UserInput.qml:41 Cannot set properties on
> flickable as it is null
is the regression you're seeing?
Making `flickable` property as "read-only" in 5.97 caused the same issue in Pure Maps and OSM Scout Server. Before, if I understood it correctly, it was recommended to set that property to your flickable which was embedded in ScrollablePage. At least that was done for my apps. As a result of Kirigami update 5.96->5.97 which got pushed out now in Flatpak platform, the apps broke on calls to ScrollablePage. (In reply to Nate Graham from comment #4) > Are you saying that this error: > > > file:///home/nate/Desktop/UserInput.qml:41 Cannot set properties on > > flickable as it is null > > is the regression you're seeing? Yes. In 5.96 & before `flickable` was an alias, as noted in the previous comment, it is set to read-only since 5.97. Got it. Perhaps we can fix this. Sorry for the regression. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/725 Git commit 27b2a4fbbdb919a54e9a825840f9e9200eaabf74 by Marco Martin. Committed on 26/08/2022 at 08:53. Pushed by mart into branch 'master'. Workaround apps that assume flickable exists before component completition upstream ScrollView can create/assign its own flickable only ater its completion, so give a provisional Flickable from the beginning which may or may not change during the component creation M +25 -19 src/controls/ScrollablePage.qml https://invent.kde.org/frameworks/kirigami/commit/27b2a4fbbdb919a54e9a825840f9e9200eaabf74 To include the above patch on top of Kirigami 5.97.0, this commit is also needed: https://invent.kde.org/frameworks/kirigami/-/commit/b5126b2bac3564908881e4c657a9470047a4b71e |