Bug 457833

Summary:	Possible to open multiple Image previews
Product:	[Applications] NeoChat	Reporter:	Jan Bidler <janbidler00>
Component:	General	Assignee:	Tobias Fella <fella>
Status:	RESOLVED FIXED
Severity:	normal	CC:	carl, james.h.graham
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Jan Bidler 2022-08-13 10:51:24 UTC

SUMMARY
It's possible to open "infinite" image previews

STEPS TO REPRODUCE
1. Have multi-monitor setup
2. Find an image in neochat
3. Click on an Image in NeoChat
4. Via meta/alt+LMB, make a formation so that neochat is on one monitor, and the image preview on another
5. Spam click the image in neochat

OBSERVED RESULT
There should only ever be one image preview

EXPECTED RESULT
You can have *a lot* of image previews. I stopped somewhere around 600 or so, as that's when NC started becoming unresponsive.


SOFTWARE/OS VERSIONS
Linux: Arch Linux
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.5
NeoChat: self compiled flatpak

Comment 1 James Graham 2022-10-23 10:26:13 UTC

The recent change to make the full screen image a popup over the Neochat window should solve this as the popup covers the image and will be closed on a second click.

https://invent.kde.org/network/neochat/-/merge_requests/551 

Can you give it a check and see if you can do this now on master?

Comment 2 Jan Bidler 2022-11-06 21:16:46 UTC

Cannot reproduce anymore, so seems fixed