| Summary: | Blurring out the answer from flags | ||
|---|---|---|---|
| Product: | [Applications] kgeography | Reporter: | mscaglione |
| Component: | general | Assignee: | Albert Astals Cid <aacid> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | lauranger, vladimir.rakhmanin |
| Priority: | NOR | Keywords: | junior-jobs |
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/education/kgeography/commit/be6af721029c8b28d1be33dca13354a6ab13b03d | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
mscaglione
2022-08-10 16:51:44 UTC
Simple approach would be to expand the xml with a flag that gets shown when asking about the flag (in opposition to the browse mode). Then we can add partially blurred versions for the flags that need them. I personally don't have the time to implement this but would be happy to help/review if someone wants to give it a go. (In reply to Albert Astals Cid from comment #1) > Simple approach would be to expand the xml with a flag that gets shown when > asking about the flag (in opposition to the browse mode). Then we can add > partially blurred versions for the flags that need them. > > I personally don't have the time to implement this but would be happy to > help/review if someone wants to give it a go. Hi there, I am currently looking to get involved with some junior jobs and would be happy to give this one a go - would that be ok? Go ahead! A possibly relevant merge request was started @ https://invent.kde.org/education/kgeography/-/merge_requests/29 Git commit be6af721029c8b28d1be33dca13354a6ab13b03d by Albert Astals Cid, on behalf of Vlad Rakhmanin. Committed on 13/09/2022 at 20:47. Pushed by aacid into branch 'master'. Implemented blurred flag feature **What does this merge request address?** This merge request relates to the Bug 457725, which suggested a new feature whereby certain flags with text on them can be blurred out, to make the flag guessing games more challenging. The flag should only be blurred in the guessing games, and in normal "browsing" mode the flag should remain unblurred. **How has the new functionality been implemented?** The map parser has been amended to now look for an additional division property entitled "blurredflag", which should contain a blurred variant of the flag. A new method has been added to the "division" class entitled "getFlagForQuestion", which returns a blurred flag if one is available. This method is now used in the flag guessing games. M +2 -0 data/brazil.kgm M +2 -0 data/flags/brazil/CMakeLists.txt A +- -- data/flags/brazil/blurred_br_PN.png A +- -- data/flags/brazil/blurred_br_RJ.png M +7 -0 data/flags/italy/CMakeLists.txt A +- -- data/flags/italy/blurred_it-cal200.png A +- -- data/flags/italy/blurred_it-emi200.png A +- -- data/flags/italy/blurred_it-lat200.png A +- -- data/flags/italy/blurred_it-mar200.png A +- -- data/flags/italy/blurred_it-mol200.png A +- -- data/flags/italy/blurred_it-pug200.png A +- -- data/flags/italy/blurred_it-ven200.png M +1 -0 data/flags/norway/CMakeLists.txt A +- -- data/flags/norway/blurred_oslo.png M +5 -1 data/flags/peru/CMakeLists.txt A +- -- data/flags/peru/blurred_amazonas.png A +- -- data/flags/peru/blurred_ancash.png A +- -- data/flags/peru/blurred_san_martin.png A +- -- data/flags/peru/blurred_tacna.png M +18 -0 data/flags/portugal/CMakeLists.txt A +- -- data/flags/portugal/blurred_aveiro.png A +- -- data/flags/portugal/blurred_beja.png A +- -- data/flags/portugal/blurred_braga.png A +- -- data/flags/portugal/blurred_braganca.png A +- -- data/flags/portugal/blurred_castelo_branco.png A +- -- data/flags/portugal/blurred_coimbra.png A +- -- data/flags/portugal/blurred_evora.png A +- -- data/flags/portugal/blurred_faro.png A +- -- data/flags/portugal/blurred_guarda.png A +- -- data/flags/portugal/blurred_leiria.png A +- -- data/flags/portugal/blurred_lisboa.png A +- -- data/flags/portugal/blurred_portalegre.png A +- -- data/flags/portugal/blurred_porto.png A +- -- data/flags/portugal/blurred_santarem.png A +- -- data/flags/portugal/blurred_setubal.png A +- -- data/flags/portugal/blurred_viana_do_castelo.png A +- -- data/flags/portugal/blurred_vila_real.png A +- -- data/flags/portugal/blurred_viseu.png M +2 -1 data/flags/ukraine/CMakeLists.txt A +- -- data/flags/ukraine/blurred_Cherkasy.png M +26 -0 data/flags/usa/CMakeLists.txt A +- -- data/flags/usa/blurred_usa_arkansas.png A +- -- data/flags/usa/blurred_usa_california.png A +- -- data/flags/usa/blurred_usa_florida.png A +- -- data/flags/usa/blurred_usa_idaho.png A +- -- data/flags/usa/blurred_usa_illinois.png A +- -- data/flags/usa/blurred_usa_iowa.png A +- -- data/flags/usa/blurred_usa_kansas.png A +- -- data/flags/usa/blurred_usa_kentucky.png A +- -- data/flags/usa/blurred_usa_maine.png A +- -- data/flags/usa/blurred_usa_minnesota.png A +- -- data/flags/usa/blurred_usa_montana.png A +- -- data/flags/usa/blurred_usa_nebraska.png A +- -- data/flags/usa/blurred_usa_nevada.png A +- -- data/flags/usa/blurred_usa_new_hampshire.png A +- -- data/flags/usa/blurred_usa_north_carolina.png A +- -- data/flags/usa/blurred_usa_north_dakota.png A +- -- data/flags/usa/blurred_usa_oklahoma.png A +- -- data/flags/usa/blurred_usa_oregon.png A +- -- data/flags/usa/blurred_usa_south_dakota.png A +- -- data/flags/usa/blurred_usa_utah.png A +- -- data/flags/usa/blurred_usa_vermont.png A +- -- data/flags/usa/blurred_usa_virginia.png A +- -- data/flags/usa/blurred_usa_washington.png A +- -- data/flags/usa/blurred_usa_west_virginia.png A +- -- data/flags/usa/blurred_usa_wisconsin.png A +- -- data/flags/usa/blurred_usa_wyoming.png M +7 -0 data/italy.kgm M +1 -0 data/norway.kgm M +4 -0 data/peru.kgm M +18 -0 data/portugal_districts.kgm M +1 -1 data/ukraine.kgm M +26 -0 data/usa.kgm M +6 -0 doc/index.docbook M +16 -0 src/division.cpp M +4 -1 src/division.h M +2 -1 src/divisionflagasker.cpp M +2 -2 src/flagdivisionasker.cpp M +10 -0 src/mapparser.cpp https://invent.kde.org/education/kgeography/commit/be6af721029c8b28d1be33dca13354a6ab13b03d |