Bug 457657

Summary: System Monitor widgets all default to the generic System Monitor widget
Product: [Plasma] plasmashell Reporter: Paul Worrall <p.r.worrall>
Component: System MonitorAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: ahiemstra, alexander.lohnau, bugseforuns, nate, notmart, plasma-bugs
Priority: VHI Keywords: regression
Version: master   
Target Milestone: 1.0   
Platform: Neon   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/commit/1768eefda2e4c063f4deead838c4b6410fced341 Version Fixed In:
Sentry Crash Report:

Description Paul Worrall 2022-08-09 07:19:59 UTC 
STEPS TO REPRODUCE
1. Right-Click desktop => Add Widgets...
2. Search for a system monitor widget, e.g. "Memory Usage", but happens with all of them
3. Drag it onto the desktop

OBSERVED RESULT
A generic "System Monitor" widget with no sensors appears on the desktop

EXPECTED RESULT
A "Memory Usage" widget with preconfigured sensors appears on the desktop

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.25.80
KDE Frameworks Version: 5.97.0
Qt Version: 5.15.5
Kernel Version: 5.15.0-43-generic (64-bit)
Graphics Platform: Wayland
Processors: 2 × AMD A6-6400K APU with Radeon(tm) HD Graphics
Memory: 7.7 GiB of RAM
Graphics Processor: AMD CEDAR
Manufacturer: NOVATECH LTD
Product Name: BB-64004H
System Version: V1.0

ADDITIONAL INFORMATION
This regression occurred about the same time as bug #454004 was fixed so maybe related to that?
Comment 1 Paul Worrall 2022-08-09 07:22:33 UTC 
Added 'regression' keyword
Comment 2 Nate Graham 2022-08-09 19:34:51 UTC 

*** This bug has been marked as a duplicate of bug 454004 ***
Comment 3 Patrick Silva 2022-08-09 19:39:19 UTC 
not a duplicate, I think. bug 454004 is fixed on neon unstable but I can reproduce the one described here.
Comment 4 Nate Graham 2022-08-10 15:11:18 UTC 
Not again...
Comment 5 Nate Graham 2022-08-10 15:11:40 UTC 
Can confirm.
Comment 6 Alexander Lohnau 2022-08-10 15:31:38 UTC 
See also https://invent.kde.org/frameworks/plasma-framework/-/commit/3078bc25dfe49bb627ae9a65cd18020054a5950e that was the rationale for https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1994.

@ahiemstra Could you please give this a look? The MR seems to have caused this issue :( Though that does not help fixing the original bug about the presets being loaded wrong.
Comment 7 Bug Janitor Service 2022-08-16 10:20:31 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2016
Comment 8 Marco Martin 2022-08-16 10:47:10 UTC 
Git commit 870ecbef9e05b6e06bb1b06a63bcb928cc609ab3 by Marco Martin.
Committed on 16/08/2022 at 10:47.
Pushed by mart into branch 'master'.

Take the pluginId from the kpackage metadata

https://invent.kde.org/plasma/plasma-workspace/-/commit/e64c13729bd1e2de43689b310caafac62f748c87
caused pluginMetadata() to be from parent applet, losing a way to load
the proper preset

M  +3    -3    applets/systemmonitor/systemmonitor/systemmonitor.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/870ecbef9e05b6e06bb1b06a63bcb928cc609ab3
Comment 9 Marco Martin 2022-08-16 14:22:26 UTC 
Git commit 1768eefda2e4c063f4deead838c4b6410fced341 by Marco Martin.
Committed on 16/08/2022 at 14:22.
Pushed by mart into branch 'Plasma/5.25'.

Take the pluginId from the kpackage metadata

https://invent.kde.org/plasma/plasma-workspace/-/commit/e64c13729bd1e2de43689b310caafac62f748c87
caused pluginMetadata() to be from parent applet, losing a way to load
the proper preset

M  +3    -3    applets/systemmonitor/systemmonitor/systemmonitor.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/1768eefda2e4c063f4deead838c4b6410fced341