Bug 457648

Summary: Square corners around details sheet
Product: [Frameworks and Libraries] frameworks-kcmutils Reporter: logicalwillow <roblokazyt>
Component: generalAssignee: Nate Graham <nate>
Status: RESOLVED FIXED    
Severity: minor CC: alexander.lohnau, nate, plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.96.0   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://invent.kde.org/frameworks/kcmutils/commit/746cd5e163b4f229e5bbb49169ac56e9b170ce83 Version Fixed/Implemented In: 5.98
Sentry Crash Report:
Attachments: Square corners around the sheet

Description logicalwillow 2022-08-09 02:56:28 UTC 
SUMMARY
The details sheet in the KWin Scripts KCM has isn't round like other Kirigami sheets. Here, there are some weird corners.

STEPS TO REPRODUCE
1. Click on the details button for a script in the list

OBSERVED RESULT
There are some strange corners around the details sheet.

EXPECTED RESULT
The sheet looks just like any other Kirigami sheet.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.25
KDE Plasma Version: 5.25.3
KDE Frameworks Version: 5.96.0
Qt Version: 5.15.5
Kernel Version: 5.15.0-43-generic (64-bit)
Graphics Platform: X11
Comment 1 logicalwillow 2022-08-09 02:56:52 UTC 
Created attachment 151180 [details]
Square corners around the sheet
Comment 2 Bug Janitor Service 2022-08-09 19:55:16 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kcmutils/-/merge_requests/97
Comment 3 Nate Graham 2022-08-09 20:38:06 UTC 
Git commit 746cd5e163b4f229e5bbb49169ac56e9b170ce83 by Nate Graham.
Committed on 09/08/2022 at 20:37.
Pushed by ngraham into branch 'master'.

KPluginSelector: Remove unnecessary background rect in About sheet

It worsens text contrast and causes visual bugs because it's being
set as the background of the entire Sheet rather than its content
item, which makes it hide the sheet's nice rounded corners. We could
fix that by setting it on the content item, removing internal padding
from the Sheet itself, and then manually re-adding it in the content
item, but that would be a lot of code to preserve something that has
less than ideal text contrast anyway, so let's just kill two birds
with one stone by removing the background color rectangle entirely.
FIXED-IN: 5.98

M  +0    -5    src/qml/components/KPluginSelector.qml

https://invent.kde.org/frameworks/kcmutils/commit/746cd5e163b4f229e5bbb49169ac56e9b170ce83