Bug 457594

Summary: The facesengine binary should be installed to AppData\Local and not AppData\Roaming
Product: [Applications] digikam Reporter: Mathias <mathias>
Component: Faces-EngineAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: 7.7.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://invent.kde.org/graphics/digikam/commit/7a8769234f5186153d0b3268e6f5f8dba9916163 Version Fixed/Implemented In: 8.0.0
Sentry Crash Report:

Description Mathias 2022-08-07 17:15:12 UTC 
STEPS TO REPRODUCE
1. Do a fresh install of DigiKam 7.7.0 on MS Windows
2. Start the software

OBSERVED RESULT

A popup window opens to download the facesengine binaries, saying that it’s a large file (>300MB) and that it will be installed to C:\Users\TheUser\AppData\Roaming\digikam\facesengine

EXPECTED RESULT

The facesengine files should be installed in the AppData\Local folder instead of AppData\Roaming as the Roaming folder is meant for (small) user-generated files that will be synced to other computers on a network while the facesengine files can easily be re-downloaded if they are missing.

SOFTWARE/OS VERSIONS
Windows: 10
Comment 1 Maik Qualmann 2022-08-07 17:24:22 UTC 
Can you give me a link there? Sometimes we get bug reports that the data should not be saved in AppData\Local and now not in AppData\Roaming? Apple stores full iPhone backups in AppData\Roaming.

Maik
Comment 2 Maik Qualmann 2022-08-07 17:29:30 UTC 
From the QStandardPath doc for AppDataLocation, the first search path is AppData/Roaming.

AppDataLocation:
"C:/Users/<USER>/AppData/Roaming/<APPNAME>",
"C:/ProgramData/<APPNAME>",
"<APPDIR>", "<APPDIR>/data",
"<APPDIR>/data/<APPNAME>"

Maik
Comment 3 Mathias 2022-08-07 17:46:43 UTC 
I don’t know of a precise documentation except about the intent to roam the data (kind of obvious). Regarding the iPhone backups, I guess this is consistent because these backups are user data that can’t be regenerated easily, so syncing them to the network makes sense.

The facesengine files on the other hand are more like a part of the digiKam setup (they are not changed by the software, they are more "the application" than "application data" if this makes sense). And softwares are usually installed to AppData\Local (see Atom editor, Chrome, MS Store apps, and all these softwares that no longer ask where they should be installed).
Comment 4 Maik Qualmann 2022-08-08 17:21:05 UTC 
Git commit 7a8769234f5186153d0b3268e6f5f8dba9916163 by Maik Qualmann.
Committed on 08/08/2022 at 17:20.
Pushed by mqualmann into branch 'master'.

move faces engine data on Windows to AppData\Local
FIXED-IN: 8.0.0

M  +1    -1    NEWS
M  +27   -0    core/app/main/main.cpp
M  +1    -1    core/libs/dimg/filters/redeye/redeyecorrectionfilter.cpp
M  +1    -1    core/libs/facesengine/detection/opencv-dnn/dnnfacedetectorssd.cpp
M  +1    -1    core/libs/facesengine/detection/opencv-dnn/dnnfacedetectoryolo.cpp
M  +1    -1    core/libs/facesengine/preprocessing/recognition/openfacepreprocessor.cpp
M  +1    -1    core/libs/facesengine/recognition/opencv-dnn/dnnfaceextractor.cpp
M  +1    -1    core/utilities/setup/downloader/filesdownloader.cpp

https://invent.kde.org/graphics/digikam/commit/7a8769234f5186153d0b3268e6f5f8dba9916163