| Summary: | No placeholder when no entries for a given mimetype found | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Nicolas Fella <nicolas.fella> |
| Component: | discover | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | aleixpol, nate |
| Priority: | NOR | Keywords: | usability |
| Version First Reported In: | master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/discover/commit/31fd4a4db304188deb351ae59e4c2765280562bb | Version Fixed/Implemented In: | 5.26 |
| Sentry Crash Report: | |||
|
Description
Nicolas Fella
2022-08-05 14:54:12 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/347 A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/347 Git commit 31fd4a4db304188deb351ae59e4c2765280562bb by Nate Graham. Committed on 08/08/2022 at 20:29. Pushed by ngraham into branch 'master'. Use correct variable to denote that ResourcesModel is done initializing Due to somewhat confusing variable naming, we were accidentally setting m_initializingBackends to false, when that variable actually holds the number of backends that are still initializing. Instead we need to set m_isInitializing to false. This fixes a bug where the placeholder message for the MIME type screen would fail to appear as expected, because one of the conditions in its opacity property was `!ResourcesModel.isInitializing` and that was never getting set to false. FIXED-IN: 5.24.7 M +1 -1 libdiscover/resources/ResourcesModel.cpp https://invent.kde.org/plasma/discover/commit/31fd4a4db304188deb351ae59e4c2765280562bb |