Bug 45751

Summary: timestamps of received offline messages is wrong
Product: [Unmaintained] kopete Reporter: Carsten Pfeiffer <pfeiffer>
Component: ICQ and AIM PluginsAssignee: Kopete Developers <kopete-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: janis.blechert
Priority: HI    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Carsten Pfeiffer 2002-07-25 16:13:07 UTC 
(*** This bug was imported into bugs.kde.org ***)

Package:           kopete
Version:           0.4.1 (using KDE 3.0.2 )
Severity:          normal
Installed from:    compiled sources
Compiler:          gcc version 2.95.3 20010315 (SuSE)
OS:                Linux (i686) release 2.4.18
OS/Compiler notes: 

Hi

kopete provides timestamps for the received messages. But it seems to get those timestamps not from the server (when the messages was written or received by the server) but locally when the message was received. 

E.g. when you receive a message that was written when you were offline and you later go online and read the message you get the current local time as timestamp.

This is with the ICQ plugin (can't test any others).

Sorry for not fixing myself I'm short on time right now.

Carsten

(Submitted via bugs.kde.org)
(Called from KBugReport dialog)
Comment 1 Till Gerken 2002-09-15 15:11:33 UTC 
Re-assigning to ICQ plugin
Comment 2 Till Gerken 2002-09-15 15:12:07 UTC 
This is correct and has been worked on by Stefan Gehn, I don't know if he fixed 
it already.
Comment 3 Unknown 2002-09-17 00:58:27 UTC 
Fixed in CVs, will appear in the next Kopete Release.
Comment 4 Paul Sandulescu 2003-12-24 08:25:12 UTC 
It says that this bug is resolved, but i'm using 0.7.4 now and i still get the current time as timestamp for offline messages on ICQ... probably on other protocols too, but this is almost the only one i use with offline messages.
Comment 5 Matt Rogers 2003-12-24 14:30:54 UTC 
then you're not using CVS. The fix for this bug is only in the 0.8 beta release or in CVS, not 0.7.4
Comment 6 Paul Sandulescu 2004-04-09 21:57:09 UTC 
Using 0.8.1 from KDE 3.2.1 in Debian unstable, I am still getting wrong timestamps in ICQ offline messages. For example, a message sent to me at 1:28pm showed me a timestamp of 06:34pm.
Comment 7 Paul Sandulescu 2004-04-09 21:58:45 UTC 
Oh, and the time I received the message was 3:04pm.
Comment 8 Stefan Gehn 2004-04-09 22:12:03 UTC 
Offline messages don't take the timezone set in the contact's userinfo into account yet. Due to that info not being persistent there is no short-term fix for it.
I have no idea where the weird times from Paul come from, I assume he just has some problems with his RTC *g*. On my system I can clearly see the offline messages are two hours "off" at the moment because I'm in GMT+2.
Comment 9 Paul Sandulescu 2004-04-10 18:39:42 UTC 
Oh, actually it seems that here they are 5 hours early since I'm in GMT-5. Even in the example below there's a difference of 5 hours. It's a bit off because of minute differences on different machines, I suppose.
Comment 10 Stefan Gehn 2004-05-10 17:21:36 UTC 
I will for sure fix this as soon as I have persistency for contact-data like timezone and the like. It's just a matter of time :)
Comment 11 Stefan Gehn 2004-06-06 13:13:29 UTC 
*** Bug 82936 has been marked as a duplicate of this bug. ***
Comment 12 Matt Rogers 2005-01-25 16:10:51 UTC 
CVS commit by mattr: 

Merge the oscar_rewrite branch into HEAD. There are a ton of changes here
and while i'm not going to go over them one by one, here's a brief overview
of some of the things that have changed.

- Delayed contact creation. Contacts aren't created on the kopete list until
  we get a confirmation back from the server that they were added correctly.
 
- Timestamps of received offline messages are correct now (#45751)

- Hopefully, many many encoding problems with message receiving are fixed
  (#88033, #97116, #43701)

- Contacts that require authorization are now marked by a red 'X' over their
  icon. 

- Asking for and getting contact list authorization should be much more 
  user friendly.

- All the reported crashes (except for two dealing with ICQ RTF) are fixed

- Contact list handling in general should be more robust.

All in all, there are just a ton of changes and hopefully, your AIM and ICQ
experience within kopete should become more enjoyable. 

BUG: 92115
BUG: 97411
BUG: 86471
BUG: 88062
BUG: 89505
BUG: 89982
BUG: 90353
BUG: 87714
BUG: 88033
BUG: 97116
BUG: 45751
BUG: 43701
BUG: 86502
BUG: 93631
BUG: 95702
BUG: 84688
BUG: 92888


  M +4 -6      Makefile.am   1.32
  M +46 -13    TODO   1.12
  M +299 -609  oscaraccount.cpp   1.161
  M +61 -131   oscaraccount.h   1.73
  M +121 -663  oscarcontact.cpp   1.166
  M +83 -196   oscarcontact.h   1.89
  M +57 -0     oscarmyselfcontact.cpp   1.2
  M +59 -0     oscarmyselfcontact.h   1.2
  M +2 -2      aim/Makefile.am   1.10
  M +91 -179   aim/aimaccount.cpp   1.50
  M +43 -54    aim/aimaccount.h   1.20
  M +158 -248  aim/aimcontact.cpp   1.65
  M +64 -74    aim/aimcontact.h   1.24
  M +23 -34    aim/aimprotocol.cpp   1.29
  M +56 -57    aim/aimprotocol.h   1.11
  M +67 -64    aim/aimuserinfo.cpp   1.18
  M +0 -1      aim/aimuserinfo.h   1.10
  M +1 -1      aim/kopete_aim.desktop   1.33
  M +1 -1      aim/ui/Makefile.am   1.4
  M +2 -4      aim/ui/aimaddcontactpage.cpp   1.10
  M +8 -14     aim/ui/aimaddcontactpage.h   1.4
  M +13 -4     aim/ui/aimeditaccountui.ui   1.31
  M +40 -35    aim/ui/aimeditaccountwidget.cpp   1.23
  M +21 -17    aim/ui/aimeditaccountwidget.h   1.9
  M +4 -7      icq/Makefile.am   1.12
  M +201 -228  icq/icqaccount.cpp   1.58
  M +70 -54    icq/icqaccount.h   1.24
  M +218 -279  icq/icqcontact.cpp   1.67
  M +86 -130   icq/icqcontact.h   1.30
  M +226 -0    icq/icqpresence.cpp   1.2
  M +176 -0    icq/icqpresence.h   1.2
  M +72 -372   icq/icqprotocol.cpp   1.63
  M +62 -73    icq/icqprotocol.h   1.17
  M +1 -1      icq/kopete_icq.desktop   1.36
  M +0 -2      icq/ui/.cvsignore   1.4
  M +7 -4      icq/ui/Makefile.am   1.5
  M +85 -344   icq/ui/icqadd.ui   1.12
  M +38 -262   icq/ui/icqaddcontactpage.cpp   1.21
  M +26 -35    icq/ui/icqaddcontactpage.h   1.8
  M +69 -0     icq/ui/icqauthreplydialog.cpp   1.2
  M +45 -0     icq/ui/icqauthreplydialog.h   1.2
  M +202 -0    icq/ui/icqauthreplyui.ui   1.2
  M +136 -141  icq/ui/icqeditaccountui.ui   1.47
  M +33 -472   icq/ui/icqeditaccountwidget.cpp   1.43
  M +19 -42    icq/ui/icqeditaccountwidget.h   1.18
  M +481 -0    icq/ui/icqgeneralinfo.ui   1.2
  M +68 -0     icq/ui/icqotherinfowidget.ui   1.2
  M +442 -0    icq/ui/icqsearchbase.ui   1.2
  M +141 -0    icq/ui/icqsearchdialog.cpp   1.2
  M +60 -0     icq/ui/icqsearchdialog.h   1.2
  M +138 -0    icq/ui/icquserinfowidget.cpp   1.2
  M +55 -0     icq/ui/icquserinfowidget.h   1.2
  M +219 -0    icq/ui/icqworkinfowidget.ui   1.2
  M +2 -0      liboscar/.cvsignore   1.2
  M +12 -0     liboscar/DESIGN   1.2
  M +194 -0    liboscar/HACKING   1.2
  M +28 -0     liboscar/Makefile.am   1.2
  M +77 -0     liboscar/TODO   1.2
  M +382 -0    liboscar/aimlogintask.cpp   1.2
  M +82 -0     liboscar/aimlogintask.h   1.2
  M +91 -0     liboscar/blmlimitstask.cpp   1.2
  M +43 -0     liboscar/blmlimitstask.h   1.2
  M +474 -0    liboscar/buffer.cpp   1.2
  M +248 -0    liboscar/buffer.h   1.2
  M +270 -0    liboscar/bytestream.cpp   1.2
  M +78 -0     liboscar/bytestream.h   1.2
  M +206 -0    liboscar/changevisibilitytask.cpp   1.2
  M +58 -0     liboscar/changevisibilitytask.h   1.2
  M +675 -0    liboscar/client.cpp   1.2
  M +368 -0    liboscar/client.h   1.2
  M +115 -0    liboscar/clientreadytask.cpp   1.2
  M +44 -0     liboscar/clientreadytask.h   1.2
  M +270 -0    liboscar/closeconnectiontask.cpp   1.2
  M +67 -0     liboscar/closeconnectiontask.h   1.2
  M +207 -0    liboscar/connection.cpp   1.2
  M +154 -0    liboscar/connection.h   1.2
  M +62 -0     liboscar/connector.cpp   1.2
  M +59 -0     liboscar/connector.h   1.2
  M +245 -0    liboscar/coreprotocol.cpp   1.2
  M +109 -0    liboscar/coreprotocol.h   1.2
  M +66 -0     liboscar/errortask.cpp   1.2
  M +39 -0     liboscar/errortask.h   1.2
  M +72 -0     liboscar/flapprotocol.cpp   1.2
  M +46 -0     liboscar/flapprotocol.h   1.2
  M +134 -0    liboscar/icbmparamstask.cpp   1.2
  M +55 -0     liboscar/icbmparamstask.h   1.2
  M +113 -0    liboscar/icqlogintask.cpp   1.2
  M +47 -0     liboscar/icqlogintask.h   1.2
  M +151 -0    liboscar/icqtask.cpp   1.2
  M +63 -0     liboscar/icqtask.h   1.2
  M +213 -0    liboscar/icquserinfo.cpp   1.2
  M +195 -0    liboscar/icquserinfo.h   1.2
  M +224 -0    liboscar/icquserinfotask.cpp   1.2
  M +75 -0     liboscar/icquserinfotask.h   1.2
  M +100 -0    liboscar/inputprotocolbase.cpp   1.2
  M +72 -0     liboscar/inputprotocolbase.h   1.2
  M +86 -0     liboscar/locationrightstask.cpp   1.2
  M +57 -0     liboscar/locationrightstask.h   1.2
  M +219 -0    liboscar/logintask.cpp   1.2
  M +144 -0    liboscar/logintask.h   1.2
  M +392 -0    liboscar/md5.c   1.2
  M +93 -0     liboscar/md5.h   1.2
  M +236 -0    liboscar/messagereceivertask.cpp   1.2
  M +102 -0    liboscar/messagereceivertask.h   1.2
  M +159 -0    liboscar/offlinemessagestask.cpp   1.2
  M +54 -0     liboscar/offlinemessagestask.h   1.2
  M +97 -0     liboscar/onlinenotifiertask.cpp   1.2
  M +60 -0     liboscar/onlinenotifiertask.h   1.2
  M +138 -0    liboscar/oscarbytestream.cpp   1.2
  M +72 -0     liboscar/oscarbytestream.h   1.2
  M +425 -0    liboscar/oscarclientstream.cpp   1.2
  M +165 -0    liboscar/oscarclientstream.h   1.2
  M +108 -0    liboscar/oscarconnector.cpp   1.2
  M +69 -0     liboscar/oscarconnector.h   1.2
  M +349 -0    liboscar/oscartypeclasses.cpp   1.2
  M +210 -0    liboscar/oscartypeclasses.h   1.2
  M +252 -0    liboscar/oscartypes.h   1.2
  M +252 -0    liboscar/oscarutils.cpp   1.2
  M +75 -0     liboscar/oscarutils.h   1.2
  M +86 -0     liboscar/ownuserinfotask.cpp   1.2
  M +53 -0     liboscar/ownuserinfotask.h   1.2
  M +72 -0     liboscar/prmparamstask.cpp   1.2
  M +42 -0     liboscar/prmparamstask.h   1.2
  M +116 -0    liboscar/profiletask.cpp   1.2
  M +56 -0     liboscar/profiletask.h   1.2
  M +228 -0    liboscar/rateclass.cpp   1.2
  M +126 -0    liboscar/rateclass.h   1.2
  M +157 -0    liboscar/rateclassmanager.cpp   1.2
  M +76 -0     liboscar/rateclassmanager.h   1.2
  M +172 -0    liboscar/rateinfotask.cpp   1.2
  M +64 -0     liboscar/rateinfotask.h   1.2
  M +2427 -0   liboscar/rtf.cc   1.2
  M +864 -0    liboscar/rtf.ll   1.2
  M +207 -0    liboscar/rtf2html.h   1.2
  M +139 -0    liboscar/safedelete.cpp   1.2
  M +79 -0     liboscar/safedelete.h   1.2
  M +94 -0     liboscar/senddcinfotask.cpp   1.2
  M +41 -0     liboscar/senddcinfotask.h   1.2
  M +57 -0     liboscar/sendidletimetask.cpp   1.2
  M +46 -0     liboscar/sendidletimetask.h   1.2
  M +203 -0    liboscar/sendmessagetask.cpp   1.2
  M +47 -0     liboscar/sendmessagetask.h   1.2
  M +166 -0    liboscar/serverversionstask.cpp   1.2
  M +57 -0     liboscar/serverversionstask.h   1.2
  M +123 -0    liboscar/servicesetuptask.cpp   1.2
  M +69 -0     liboscar/servicesetuptask.h   1.2
  M +102 -0    liboscar/snacprotocol.cpp   1.2
  M +46 -0     liboscar/snacprotocol.h   1.2
  M +50 -0     liboscar/ssiactivatetask.cpp   1.2
  M +38 -0     liboscar/ssiactivatetask.h   1.2
  M +196 -0    liboscar/ssiauthtask.cpp   1.2
  M +60 -0     liboscar/ssiauthtask.h   1.2
  M +157 -0    liboscar/ssilisttask.cpp   1.2
  M +109 -0    liboscar/ssilisttask.h   1.2
  M +429 -0    liboscar/ssimanager.cpp   1.2
  M +131 -0    liboscar/ssimanager.h   1.2
  M +448 -0    liboscar/ssimodifytask.cpp   1.2
  M +127 -0    liboscar/ssimodifytask.h   1.2
  M +99 -0     liboscar/ssiparamstask.cpp   1.2
  M +43 -0     liboscar/ssiparamstask.h   1.2
  M +31 -0     liboscar/stream.cpp   1.2
  M +75 -0     liboscar/stream.h   1.2
  M +286 -0    liboscar/task.cpp   1.2
  M +114 -0    liboscar/task.h   1.2
  M +367 -0    liboscar/transfer.cpp   1.2
  M +169 -0    liboscar/transfer.h   1.2
  M +354 -0    liboscar/userdetails.cpp   1.2
  M +85 -0     liboscar/userdetails.h   1.2
  M +153 -0    liboscar/userinfotask.cpp   1.2
  M +69 -0     liboscar/userinfotask.h   1.2
  M +173 -0    liboscar/usersearchtask.cpp   1.2
  M +61 -0     liboscar/usersearchtask.h   1.2
  M +93 -0     liboscar/warningtask.cpp   1.2
  M +59 -0     liboscar/warningtask.h   1.2
  M +7 -0      liboscar/tests/.cvsignore   1.2
  M +19 -0     liboscar/tests/Makefile.am   1.2
  M +49 -0     liboscar/tests/clientstream_test.cpp   1.2
  M +49 -0     liboscar/tests/clientstream_test.h   1.2
  M +56 -0     liboscar/tests/logintest.cpp   1.2
  M +53 -0     liboscar/tests/logintest.h   1.2
  M +73 -0     liboscar/tests/ssigrouptest.cpp   1.2
  M +54 -0     liboscar/tests/ssigrouptest.h   1.2
  M +111 -0    liboscar/tests/ssitest.cpp   1.2
  M +34 -0     liboscar/tests/ssitest.h   1.2
  M +67 -0     liboscar/tests/userinfotest.cpp   1.2
  M +53 -0     liboscar/tests/userinfotest.h   1.2
  R            Doxyfile   1.3
  R            README.login   1.1
  R            icq/icqsendsmsdialog.cpp   1.1
  R            icq/icqsendsmsdialog.h   1.1
  R            icq/icquserinfo.cpp   1.21
  R            icq/icquserinfo.h   1.11
  R            oscarsocket/.cvsignore   1.1
  R            oscarsocket/Makefile.am   1.25
  R            oscarsocket/aim.cpp   1.9
  R            oscarsocket/aim.h   1.8
  R            oscarsocket/buffer.cpp   1.44
  R            oscarsocket/buffer.h   1.31
  R            oscarsocket/md5.c   1.1
  R            oscarsocket/md5.h   1.1
  R            oscarsocket/oncomingsocket.cpp   1.23
  R            oscarsocket/oncomingsocket.h   1.11
  R            oscarsocket/oscar_fam01.cpp   1.3
  R            oscarsocket/oscar_fam04.cpp   1.10
  R            oscarsocket/oscar_fam19.cpp   1.10
  R            oscarsocket/oscarcaps.cpp   1.5
  R            oscarsocket/oscarcaps.h   1.4
  R            oscarsocket/oscarconnection.cpp   1.32
  R            oscarsocket/oscarconnection.h   1.24
  R            oscarsocket/oscardebug.h   1.5
  R            oscarsocket/oscardirectconnection.cpp   1.24
  R            oscarsocket/oscardirectconnection.h   1.10
  R            oscarsocket/oscarfilesendconnection.cpp   1.14
  R            oscarsocket/oscarfilesendconnection.h   1.8
  R            oscarsocket/oscarmessage.cpp   1.6
  R            oscarsocket/oscarmessage.h   1.1
  R            oscarsocket/oscarsocket.aim.cpp   1.33
  R            oscarsocket/oscarsocket.cpp   1.213
  R            oscarsocket/oscarsocket.h   1.126
  R            oscarsocket/oscarsocket.icq.cpp   1.73
  R            oscarsocket/oscarsocket.icq.h   1.14
  R            oscarsocket/oscartypes.h   1.9
  R            oscarsocket/rateclass.cpp   1.5
  R            oscarsocket/rateclass.h   1.3
  R            oscarsocket/rtf.cc   1.5
  R            oscarsocket/rtf.ll   1.5
  R            oscarsocket/rtf2html.h   1.2
  R            oscarsocket/ssidata.cpp   1.22
  R            oscarsocket/ssidata.h   1.16