Bug 457429

Summary: 5.25.4: test suite is failing
Product: [Unmaintained] kdeplasma-addons Reporter: kloczek <kloczko.tomasz>
Component: dictionaryAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED WORKSFORME    
Severity: normal CC: alexander.lohnau, nate
Priority: NOR    
Version First Reported In: 5.25.4   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description kloczek 2022-08-03 00:22:45 UTC
Looks like test suite is faiing in spellcheckrunnertest unit

+ cd kdeplasma-addons-5.25.4
+ xvfb-run -a /usr/bin/make -O -j48 V=1 VERBOSE=1 -C x86_64-redhat-linux-gnu test ARGS=--output-on-failure
make: Entering directory '/home/tkloczko/rpmbuild/BUILD/kdeplasma-addons-5.25.4/x86_64-redhat-linux-gnu'
Running tests...
/usr/bin/ctest --force-new-ctest-process --output-on-failure
Test project /home/tkloczko/rpmbuild/BUILD/kdeplasma-addons-5.25.4/x86_64-redhat-linux-gnu
    Start 1: converterrunnertest
1/2 Test #1: converterrunnertest ..............   Passed    0.19 sec
    Start 2: spellcheckrunnertest
2/2 Test #2: spellcheckrunnertest .............***Failed    0.27 sec
********* Start testing of SpellCheckRunnerTest *********
Config: Using QtTest library 5.15.5, Qt 5.15.5 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.1.1 20220628 (Red Hat 12.1.1-3)), fedora 37
PASS   : SpellCheckRunnerTest::initTestCase()
FAIL!  : SpellCheckRunnerTest::testDefaultDictionary() Compared values are not the same
   Actual   (matches.count()): 5
   Expected (1)              : 1
   Loc: [/home/tkloczko/rpmbuild/BUILD/kdeplasma-addons-5.25.4/runners/spellchecker/autotests/spellcheckrunnertest.cpp(56)]
FAIL!  : SpellCheckRunnerTest::testSpecifiedDictionary() Compared values are not the same
   Actual   (matches.count()): 0
   Expected (1)              : 1
   Loc: [/home/tkloczko/rpmbuild/BUILD/kdeplasma-addons-5.25.4/runners/spellchecker/autotests/spellcheckrunnertest.cpp(76)]
SKIP   : SpellCheckRunnerTest::testAutomaticDictionary() ru_RU dictionary is not available.
   Loc: [/home/tkloczko/rpmbuild/BUILD/kdeplasma-addons-5.25.4/runners/spellchecker/autotests/spellcheckrunnertest.cpp(113)]
FAIL!  : SpellCheckRunnerTest::testSuggestions() 'std::any_of(matches.cbegin(), matches.cend(), [](const Plasma::QueryMatch &match) { return match.text() == QStringLiteral("hello") && match.iconName() == QStringLiteral("edit-rename"); })' returned FALSE. ()
   Loc: [/home/tkloczko/rpmbuild/BUILD/kdeplasma-addons-5.25.4/runners/spellchecker/autotests/spellcheckrunnertest.cpp(149)]
PASS   : SpellCheckRunnerTest::cleanupTestCase()
Totals: 2 passed, 3 failed, 1 skipped, 0 blacklisted, 122ms
********* Finished testing of SpellCheckRunnerTest *********


50% tests passed, 1 tests failed out of 2

Total Test time (real) =   0.47 sec

The following tests FAILED:
          2 - spellcheckrunnertest (Failed)
Errors while running CTest
Comment 1 Nate Graham 2022-08-04 19:04:42 UTC
Both tests pass for me:

Test project /home/nate/kde/build/kdeplasma-addons
    Start 1: converterrunnertest
1/2 Test #1: converterrunnertest ..............   Passed    2.37 sec
    Start 2: spellcheckrunnertest
2/2 Test #2: spellcheckrunnertest .............   Passed    0.13 sec

Can you dig into the failure and figure out why that test is failing for you?
Comment 2 kloczek 2022-08-04 22:27:57 UTC
> Can you dig into the failure and figure out why that test is failing for you?

So what exactly you want me to so?
Are able to reproduce that issue?
Comment 3 Nate Graham 2022-08-05 03:17:26 UTC
(In reply to kloczek from comment #2)
> > Can you dig into the failure and figure out why that test is failing for you?
> 
> So what exactly you want me to so?
See if you can figure out why it's failing for you.

> Are able to reproduce that issue?
No, the test passes for me.
Comment 4 kloczek 2022-08-05 15:55:05 UTC
(In reply to Nate Graham from comment #3)
> > Are able to reproduce that issue?
> No, the test passes for me.

So what that unit is doing and why possibly is failing?
Comment 5 Nate Graham 2022-08-05 16:06:02 UTC
That's for you to figure out, because you're the one for whom it's failing. :) You need to show that it's an issue in our code and not just a local misconfiguration on your machine.
Comment 6 kloczek 2022-08-05 16:19:44 UTC
(In reply to Nate Graham from comment #5)
> That's for you to figure out, because you're the one for whom it's failing.
> :) You need to show that it's an issue in our code and not just a local
> misconfiguration on your machine.

So you did not wrote that unit and you don;t know why it may fail?
If yes who may know?
Comment 7 Nate Graham 2022-08-05 16:30:14 UTC
No, I didn't write it.

I figured that if you're running the test suite, you're a developer, and you can look into the failure yourself.

Is that not the case?
Comment 8 Bug Janitor Service 2022-08-20 04:35:29 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 9 Bug Janitor Service 2022-09-04 04:36:05 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!