Bug 457189

Summary: kde-mac/kde/kf5-plasma-framework 5.96.0 won't build
Product: [Frameworks and Libraries] libplasma Reporter: Yuriy Davygora <davygora>
Component: libplasmaAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: davygora, me, nicolas.fella, notmart, yurii.kolesnykov
Priority: NOR    
Version: 5.96.0   
Target Milestone: ---   
Platform: Homebrew (macOS)   
OS: macOS   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: attachment-28296-0.html

Description Yuriy Davygora 2022-07-27 09:50:34 UTC
Upgrading with Homebrew from kde-mac/kde/kf5-plasma-framework 5.95.0 to 5.96.0 doesn't work on macOS Monterey 12.04 (Intel). 


STEPS TO REPRODUCE
1. brew upgrade kf5-plasma-framework

OBSERVED RESULT
==> Upgrading 1 outdated package:
kde-mac/kde/kf5-plasma-framework 5.95.0 -> 5.96.0
==> Downloading https://invent.kde.org/frameworks/plasma-framework/-/commit/dff1b034c1162062aa2292099d3d01fc53dafdf6.diff
Already downloaded: /Users/yuriy.davygora/Library/Caches/Homebrew/downloads/096c8204bd851e091d267b16a523cff03bd5b74da88e0898bd35ae8ac29844a7--dff1b034c1162062aa2292099d3d01fc53dafdf6.diff
==> Downloading https://download.kde.org/stable/frameworks/5.96/plasma-framework-5.96.0.tar.xz
Already downloaded: /Users/yuriy.davygora/Library/Caches/Homebrew/downloads/c1d2bebdc7c8957bc24bd2ca2aa9c5c5083599d18abe7ba146dbd051dbceb344--plasma-framework-5.96.0.tar.xz
==> Upgrading kde-mac/kde/kf5-plasma-framework
  5.95.0 -> 5.96.0

==> Patching
==> Applying dff1b034c1162062aa2292099d3d01fc53dafdf6.diff
patching file CMakeLists.txt
Hunk #1 FAILED at 118.
1 out of 1 hunk FAILED -- saving rejects to file CMakeLists.txt.rej
patching file src/declarativeimports/core/CMakeLists.txt
Hunk #1 FAILED at 70.
1 out of 1 hunk FAILED -- saving rejects to file src/declarativeimports/core/CMakeLists.txt.rej

Do not report this issue to Homebrew/brew or Homebrew/core!

Error: Validation Failed: [{"message"=>"The listed users and repositories cannot be searched either because the resources do not exist or you do not have permission to view them.", "resource"=>"Search", "field"=>"q", "code"=>"invalid"}]

EXPECTED RESULT

kde-mac/kde/kf5-plasma-framework upgrades successfully

SOFTWARE/OS VERSIONS
macOS Monterey 12.04
Comment 1 Nicolas Fella 2022-07-27 10:52:17 UTC
This is not a problem with plasma-framework, it's the homebrew package that's broken.

Besides that, why are you building plasma-framework on macOS in the first place? There shouldn't be a reason to do that at all
Comment 2 Yuriy Davygora 2022-07-27 10:59:06 UTC
(In reply to Nicolas Fella from comment #1)
> This is not a problem with plasma-framework, it's the homebrew package
> that's broken.
> 
> Besides that, why are you building plasma-framework on macOS in the first
> place? There shouldn't be a reason to do that at all

1. The Homebrew package is maintained by the owners of the kde-mac tap, https://invent.kde.org/packaging/homebrew-kde, which is, as I understand it, part of the KDE team.
2. Both kate and kolourpaint depend on plasma framework, and I use both of them on macOS simply because they are by far better than any possible native macOS solutions.
Comment 3 Nicolas Fella 2022-07-27 11:06:07 UTC
Kate does not require plasma-framework, it only optionally uses that for building the session applet, which is not useful on macOS anyway

I don't see why Kolourpaint would need plasma-framework at all.

This sounds like something to be fixed in the formulas
Comment 4 Dawid Wróbel 2022-07-27 11:07:05 UTC
Git commit 4f5d107f7562d90061a16edabe7298e886df6c28 by Dawid Wróbel.
Committed on 27/07/2022 at 11:07.
Pushed by wrobelda into branch 'master'.

kf5-plasma-framework: remove a merged patch

M  +0    -5    Formula/kf5-plasma-framework.rb

https://invent.kde.org/packaging/homebrew-kde/commit/4f5d107f7562d90061a16edabe7298e886df6c28
Comment 5 Dawid Wróbel 2022-07-27 11:18:55 UTC
Created attachment 150940 [details]
attachment-28296-0.html

> This sounds like something to be fixed in the formulas

Indeed. Aded a relevant issue to track it:
https://invent.kde.org/packaging/homebrew-kde/-/issues/45


On Wed, Jul 27, 2022 at 1:06 PM Nicolas Fella <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=457189
>
> --- Comment #3 from Nicolas Fella <nicolas.fella@gmx.de> ---
> Kate does not require plasma-framework, it only optionally uses that for
> building the session applet, which is not useful on macOS anyway
>
> I don't see why Kolourpaint would need plasma-framework at all.
>
> This sounds like something to be fixed in the formulas
>
> --
> You are receiving this mail because:
> You are watching all bug changes.
>
>
Comment 6 Nicolas Fella 2022-07-27 11:22:03 UTC
Thanks Dawid!
Comment 7 Yuriy Davygora 2022-07-27 11:26:32 UTC
Yes, thanks Dawid!

And sorry everyone for misleading you all, you were right, kolourpaint indeed does not depend on the plasma framework, my mistake.