Bug 457185

Summary:	Craft digiKam MacOS : libgphoto2 packaging problem.
Product:	[Unmaintained] Craft	Reporter:	caulier.gilles
Component:	Blueprints	Assignee:	Hannah von Reth <vonreth>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	windows-bugs-null
Priority:	NOR
Version First Reported In:	master
Target Milestone:	---
Platform:	macOS (DMG)
OS:	macOS
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description caulier.gilles 2022-07-27 05:58:58 UTC

Hi all,

While building digiKam for MacOS, libgphoto dependency is detected and code relevant is compiled fine.
If libgphoto and libusb-compat are not integrated a runtime dependencies, digiKAm will not start on MacOS as these component are missing in the bundle.

Adding libgphoto2 introduce a new packaging problem with libgphoto2_port and libgphoto2 directories:

...
23:55:14  executing command: /usr/bin/codesign --keychain /Users/packaging/Library/Keychains/login.keychain --sign Developer ID Application: K Desktop Environment e.V. (5433B4KXM8) --force --preserve-metadata=identifier,entitlements --options runtime --verbose=99 --timestamp --deep /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/extragear/digikam/archive/Applications/KDE/digikam.app
23:59:09  /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/extragear/digikam/archive/Applications/KDE/digikam.app: bundle format unrecognized, invalid, or unsuitable
23:59:09  In subcomponent: /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/extragear/digikam/archive/Applications/KDE/digikam.app/Contents/Frameworks/libgphoto2_port/0.12.0
23:59:09  Command ['/usr/bin/codesign', '--keychain', '/Users/packaging/Library/Keychains/login.keychain', '--sign', 'Developer ID Application: K Desktop Environment e.V. (5433B4KXM8)', '--force', '--preserve-metadata=identifier,entitlements', '--options', 'runtime', '--verbose=99', '--timestamp', '--deep', '/Users/packaging/Craft/BinaryFactory/macos-64-clang/build/extragear/digikam/archive/Applications/KDE/digikam.app'] failed with exit code 1
23:59:09  Action: package for extragear/digikam:master FAILED
...

...
06:47:06  executing command: /usr/bin/codesign --keychain /Users/packaging/Library/Keychains/login.keychain --sign Developer ID Application: K Desktop Environment e.V. (5433B4KXM8) --force --preserve-metadata=identifier,entitlements --options runtime --verbose=99 --timestamp --deep /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/extragear/digikam/archive/Applications/KDE/digikam.app
06:51:01  /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/extragear/digikam/archive/Applications/KDE/digikam.app: bundle format unrecognized, invalid, or unsuitable
06:51:01  In subcomponent: /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/extragear/digikam/archive/Applications/KDE/digikam.app/Contents/Frameworks/libgphoto2/2.5.27
06:51:01  Command ['/usr/bin/codesign', '--keychain', '/Users/packaging/Library/Keychains/login.keychain', '--sign', 'Developer ID Application: K Desktop Environment e.V. (5433B4KXM8)', '--force', '--preserve-metadata=identifier,entitlements', '--options', 'runtime', '--verbose=99', '--timestamp', '--deep', '/Users/packaging/Craft/BinaryFactory/macos-64-clang/build/extragear/digikam/archive/Applications/KDE/digikam.app'] failed with exit code 1
06:51:01  Action: package for extragear/digikam:master FAILED
...

Why signing files in these directory do not work ?

Best

Gilles Caulier

Comment 1 Hannah von Reth 2022-07-27 06:49:18 UTC

Hi Gilles,

The mac code signing doesn't like folders with '.' in the Frameworks folder.
I'd suggest to patch libgphoto to not install dot folders.
If libgphoto2_port/0.12.0 doesn't contain libraries it should not be in the Frameworks folder at all.


Btw, 
This is the craft bug tracker, not stackoverflow or a mailing list.
Cheers,

Hannah