Bug 457129

Summary:	Discover erroneously reboots system when update is canceled and "reboot after update" checkbox is checked
Product:	[Applications] Discover	Reporter:	Gurenko Alex <agurenko>
Component:	Updates	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aleixpol, nate
Priority:	NOR
Version First Reported In:	5.25.3
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	e6db01be70f6ce161aa3d7c525503f9db42954c6	Version Fixed In:	5.25
Sentry Crash Report:

Description Gurenko Alex 2022-07-25 18:10:35 UTC

SUMMARY

When Discover downloads update and update process is cancelled the system is still sent into reboot


STEPS TO REPRODUCE
1. When system updates are available click "Update All"
2. Mark "Reboot system as soon as download is completed
3. Cancel update

OBSERVED RESULT

System is reboot immediately

EXPECTED RESULT

If no updates is cancelled system should not be rebooted


SOFTWARE/OS VERSIONS
Linux/KDE Plasma:  Fedora Linux 36 KDE
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.96
Qt Version: 5.15.3

ADDITIONAL INFORMATION

Comment 1 Aleix Pol 2022-07-26 18:40:37 UTC

This is fixed in Plasma 5.25.

*** This bug has been marked as a duplicate of bug 452165 ***

Comment 2 Nate Graham 2022-07-26 19:53:49 UTC

wrong dupe bug?

Comment 3 Aleix Pol 2022-07-26 23:01:22 UTC

Ehm clearly... I guess I tried to close the wrong bug with this commit.

In any case it should be fixed.

commit e6db01be70f6ce161aa3d7c525503f9db42954c6
Author: Aleix Pol <aleixpol@kde.org>
Date:   Thu May 5 17:11:32 2022 +0200

    updates: Do not reboot if one of the update transactions failed
    
    It gives the user the chance to see what went down.
    
    BUG: 452165