Bug 456917

Summary: Crash when closing Yakuake
Product: [Applications] yakuake Reporter: Nicolas Fella <nicolas.fella>
Component: generalAssignee: Eike Hein <hein>
Status: RESOLVED FIXED    
Severity: crash CC: bugseforuns, nate
Priority: NOR    
Version First Reported In: Git (Frameworks 5)   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/utilities/yakuake/commit/2551725589e6b748e3c2a49452ac44e0525e5736 Version Fixed/Implemented In: 22.08.1
Sentry Crash Report:

Description Nicolas Fella 2022-07-19 14:40:20 UTC 
STEPS TO REPRODUCE
1. Open Yakuake
2. Press close button

Everything from master

#0  Session::wantsBlur (this=0x872750) at /home/nico/kde/src/yakuake/app/session.cpp:660
#1  0x0000000000439941 in operator() (session=<optimized out>, __closure=<synthetic pointer>) at /home/nico/kde/src/yakuake/app/sessionstack.cpp:769
#2  __gnu_cxx::__ops::_Iter_pred<SessionStack::wantsBlur() const::<lambda(Session*)> >::operator()<QHash<int, Session*>::const_iterator> (__it=..., this=<synthetic pointer>) at /usr/include/c++/12/bits/predefined_ops.h:318
#3  std::__find_if<QHash<int, Session*>::const_iterator, __gnu_cxx::__ops::_Iter_pred<SessionStack::wantsBlur() const::<lambda(Session*)> > > (__pred=..., __last=..., __first=...) at /usr/include/c++/12/bits/stl_algobase.h:2050
#4  std::__find_if<QHash<int, Session*>::const_iterator, __gnu_cxx::__ops::_Iter_pred<SessionStack::wantsBlur() const::<lambda(Session*)> > > (__pred=..., __last=..., __first=...) at /usr/include/c++/12/bits/stl_algobase.h:2112
#5  std::find_if<QHash<int, Session*>::const_iterator, SessionStack::wantsBlur() const::<lambda(Session*)> > (__pred=..., __last=..., __first=...) at /usr/include/c++/12/bits/stl_algo.h:3877
#6  std::none_of<QHash<int, Session*>::const_iterator, SessionStack::wantsBlur() const::<lambda(Session*)> > (__pred=..., __last=..., __first=...) at /usr/include/c++/12/bits/stl_algo.h:474
#7  std::any_of<QHash<int, Session*>::const_iterator, SessionStack::wantsBlur() const::<lambda(Session*)> > (__pred=..., __last=..., __first=...) at /usr/include/c++/12/bits/stl_algo.h:493
#8  SessionStack::wantsBlur (this=<optimized out>) at /home/nico/kde/src/yakuake/app/sessionstack.cpp:768
#9  0x0000000000428387 in MainWindow::applyWindowProperties (this=0x7fffffffd5b0) at /home/nico/kde/src/yakuake/app/mainwindow.cpp:938
#10 0x00007ffff5d0c3a4 in QtPrivate::QSlotObjectBase::call (a=0x7fffffffd0b0, r=0x7fffffffd5b0, this=0x636400) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#11 doActivate<false> (sender=0x543190, signal_index=19, argv=0x7fffffffd0b0) at kernel/qobject.cpp:3886
#12 0x00007ffff5d0c3a4 in QtPrivate::QSlotObjectBase::call (a=0x7fffffffd160, r=0x543190, this=0x8ad820) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#13 doActivate<false> (sender=0x78bfa0, signal_index=10, argv=0x7fffffffd160) at kernel/qobject.cpp:3886
#14 0x00007ffff5d05c1f in QMetaObject::activate (sender=sender@entry=0x78bfa0, m=m@entry=0x469720 <Session::staticMetaObject>, local_signal_index=local_signal_index@entry=7, argv=argv@entry=0x0) at kernel/qobject.cpp:3946
#15 0x0000000000419973 in Session::wantsBlurChanged (this=this@entry=0x78bfa0) at /home/nico/kde/build/yakuake/app/yakuake_autogen/EWIEGA46WW/moc_session.cpp:356
#16 0x0000000000435bf4 in Session::cleanup (this=0x78bfa0, terminalId=0) at /home/nico/kde/src/yakuake/app/session.cpp:384
#17 0x00007ffff5d0c3d4 in doActivate<false> (sender=0x7a3f80, signal_index=9, argv=0x7fffffffd2b0) at kernel/qobject.cpp:3898
#18 0x00007ffff5d05c1f in QMetaObject::activate (sender=sender@entry=0x7a3f80, m=m@entry=0x4695e0 <Terminal::staticMetaObject>, local_signal_index=local_signal_index@entry=6, argv=argv@entry=0x7fffffffd2b0) at kernel/qobject.cpp:3946
#19 0x0000000000419ea1 in Terminal::destroyed (this=this@entry=0x7a3f80, _t1=<optimized out>) at /home/nico/kde/build/yakuake/app/yakuake_autogen/EWIEGA46WW/moc_terminal.cpp:302
#20 0x000000000044771a in Terminal::~Terminal (this=0x7a3f80, __in_chrg=<optimized out>) at /home/nico/kde/src/yakuake/app/terminal.cpp:113
#21 Terminal::~Terminal (this=0x7a3f80, __in_chrg=<optimized out>) at /home/nico/kde/src/yakuake/app/terminal.cpp:114
#22 0x00007ffff5cff18e in QObjectPrivate::deleteChildren (this=this@entry=0x79a140) at kernel/qobject.cpp:2104
#23 0x00007ffff6836d26 in QWidget::~QWidget (this=this@entry=0x772de0, __in_chrg=<optimized out>) at kernel/qwidget.cpp:1522
#24 0x00007ffff68e10ed in QFrame::~QFrame (this=this@entry=0x772de0, __in_chrg=<optimized out>) at widgets/qframe.cpp:264
#25 0x00007ffff69978b3 in QSplitter::~QSplitter (this=this@entry=0x772de0, __in_chrg=<optimized out>) at widgets/qsplitter.cpp:979
#26 0x00000000004411a1 in Splitter::~Splitter (this=0x772de0, __in_chrg=<optimized out>) at /home/nico/kde/src/yakuake/app/splitter.cpp:18
#27 Splitter::~Splitter (this=0x772de0, __in_chrg=<optimized out>) at /home/nico/kde/src/yakuake/app/splitter.cpp:18
#28 0x0000000000434816 in Session::~Session (this=0x78bfa0, __in_chrg=<optimized out>) at /home/nico/kde/src/yakuake/app/session.cpp:35
#29 0x0000000000434909 in Session::~Session (this=0x78bfa0, __in_chrg=<optimized out>) at /home/nico/kde/src/yakuake/app/session.cpp:38
#30 0x00007ffff5cff18e in QObjectPrivate::deleteChildren (this=this@entry=0x537e20) at kernel/qobject.cpp:2104
#31 0x00007ffff6836d26 in QWidget::~QWidget (this=this@entry=0x543190, __in_chrg=<optimized out>) at kernel/qwidget.cpp:1522
#32 0x00007ffff68e10ed in QFrame::~QFrame (this=this@entry=0x543190, __in_chrg=<optimized out>) at widgets/qframe.cpp:264
#33 0x00007ffff699c73d in QStackedWidget::~QStackedWidget (this=this@entry=0x543190, __in_chrg=<optimized out>) at widgets/qstackedwidget.cpp:147
#34 0x0000000000437b8e in SessionStack::~SessionStack (this=0x543190, __in_chrg=<optimized out>) at /home/nico/kde/src/yakuake/app/sessionstack.cpp:36
#35 SessionStack::~SessionStack (this=0x543190, __in_chrg=<optimized out>) at /home/nico/kde/src/yakuake/app/sessionstack.cpp:36
#36 0x00007ffff5cff18e in QObjectPrivate::deleteChildren (this=this@entry=0x46d620) at kernel/qobject.cpp:2104
#37 0x00007ffff6836d26 in QWidget::~QWidget (this=0x7fffffffd5b0, __in_chrg=<optimized out>) at kernel/qwidget.cpp:1522
#38 0x00007ffff6941a7d in QMainWindow::~QMainWindow (this=<optimized out>, __in_chrg=<optimized out>) at widgets/qmainwindow.cpp:378
#39 0x00007ffff7bcc629 in KMainWindow::~KMainWindow (this=<optimized out>, __in_chrg=<optimized out>) at /home/nico/kde/src/kxmlgui/src/kmainwindow.cpp:441
#40 0x0000000000419456 in main (argc=<optimized out>, argv=<optimized out>) at /home/nico/kde/src/yakuake/app/main.cpp:75
Comment 2 Bug Janitor Service 2022-08-05 10:52:20 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/utilities/yakuake/-/merge_requests/75
Comment 3 Nicolas Fella 2022-08-09 11:15:52 UTC 
Git commit 35bed35bb88c12121502a515172e33ad9a037823 by Nicolas Fella.
Committed on 05/08/2022 at 10:49.
Pushed by nicolasfella into branch 'release/22.08'.

Don't emit wantsBlurChanged when cleaning up session

This causes a use-after-free crash when recomputing wantsBlur

Not a pretty fix, but the proper solution is more involved

M  +0    -1    app/session.cpp

https://invent.kde.org/utilities/yakuake/commit/35bed35bb88c12121502a515172e33ad9a037823
Comment 4 Nicolas Fella 2022-08-22 20:27:07 UTC 
Git commit 2551725589e6b748e3c2a49452ac44e0525e5736 by Nicolas Fella.
Committed on 22/08/2022 at 20:26.
Pushed by nicolasfella into branch 'master'.

Revise ownership of terminal instances

Currently the Terminal objects are parented to the base splitter

When they are destroyed the session reacts to that and removes them from its internal map

This is rather complex and causes a crash when closing the app

Instead have the session own the terminals (and manage them using unique_ptr)

This is complicated by the fact that the part instance deletes itself when the terminal is exited by the user

In that case notify the session that the terminal wants to be deleted and clean up accordingly

M  +37   -35   app/session.cpp
M  +1    -1    app/session.h
M  +16   -12   app/terminal.cpp
M  +3    -0    app/terminal.h

https://invent.kde.org/utilities/yakuake/commit/2551725589e6b748e3c2a49452ac44e0525e5736