Bug 456895

Summary: Skrooge seems to work better under Wayland, so remove broken Wayland override
Product: [Applications] skrooge Reporter: skierpage <info>
Component: generalAssignee: Guillaume DE BURE <guillaume.debure>
Status: RESOLVED FIXED    
Severity: normal CC: stephane
Priority: NOR    
Version First Reported In: Trunk from git   
Target Milestone: 25.1.0   
Platform: Flatpak   
OS: Linux   
Latest Commit: https://invent.kde.org/office/skrooge/commit/6b7a86d88070a23dedd4dc546411ab0a2ab1b697 Version Fixed/Implemented In:
Sentry Crash Report:

Description skierpage 2022-07-19 04:08:21 UTC 
SUMMARY
I've closed bug 451476 and updated bug 446352 because Good news: I haven't experienced a crash in about a month of light Skrooge use, in which Skrooge runs under Wayland Also Skrooge hasn't hung, field popup lists are generally positioned better; I created a transfer operation and there was no crash.

So Skrooge appears to be working OK run in Wayland. So the code in commit c7fd9964a, "disregarding XDG_SESSION_TYPE=wayland" that tries to force XCB is no longer necessary. And as I wrote in comment 4 on bug 446352, it _doesn't work_. When I start the Skrooge nightly flatpak, I get
> ##Warning: disregarding XDG_SESSION_TYPE=wayland
> ##To use wayland anyway, please set QT_QPA_PLATFORM=wayland
; I don't have QT_QPA_PLATFORM set, yet Help > About Skrooge > Components still shows "The Wayland windowing system"

STEPS TO REPRODUCE
1. Start KDE using Wayland
2. Run Skrooge flatpak from the command line.
3. Choose Help > About Skrooge > Components

OBSERVED RESULT
Notice the misleading console warning about session type and QT_QPA_PLATFORM; notice no crashes and OK performance in Wayland; notice Skrooge is in fact running under Wayland.

EXPECTED RESULT
Remove commit c7fd9964a

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
KDE Plasma Version: 5.25.3
KDE Frameworks Version: 5.96.0
Qt Version: 5.15.5

ADDITIONAL INFORMATION
It's probably best just to remove the misleading CHANGELOG for the old non-fix for Wayland problems
> *Correction bug 446352: field pop-ups located weirdly, "##WARNING: Wayland does not support QWindow::requestActivate()", sometimes hangs
Comment 1 Stephane MANKOWSKI 2022-10-01 09:47:42 UTC 
Git commit 6b7a86d88070a23dedd4dc546411ab0a2ab1b697 by Stephane Mankowski.
Committed on 01/10/2022 at 09:47.
Pushed by smankowski into branch 'master'.

Skrooge seems to work better under Wayland, so remove broken Wayland override

M  +1    -0    CHANGELOG
M  +0    -7    skrooge/main.cpp

https://invent.kde.org/office/skrooge/commit/6b7a86d88070a23dedd4dc546411ab0a2ab1b697