Bug 456889

Summary: Rename "Applications" in sidebar to "All Applications"
Product: [Applications] Discover Reporter: logicalwillow <roblokazyt>
Component: discoverAssignee: Dan Leinir Turthra Jensen <leinir>
Status: RESOLVED FIXED    
Severity: wishlist CC: aleixpol, bugseforuns, nate
Priority: NOR    
Version First Reported In: 5.25.3   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 5.25.4
Sentry Crash Report:
Attachments: Screenshot of the sidebar in Discover

Description logicalwillow 2022-07-18 22:56:34 UTC
Created attachment 150722 [details]
Screenshot of the sidebar in Discover

SUMMARY
The "Applications" item in the sidebar seems out of place IMO. I think it would be a good idea to move it to the top and rename it to "All Applications".

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.25
KDE Plasma Version: 5.25.3
KDE Frameworks Version: 5.96.0
Qt Version: 5.15.5
Graphics Platform: X11
Comment 1 Nate Graham 2022-07-19 19:17:17 UTC
Yeah.
Comment 2 Bug Janitor Service 2022-07-20 15:36:28 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/328
Comment 3 Aleix Pol 2022-07-20 23:10:49 UTC
Git commit 6ce3ca31870e9d1d954f4437aeab4c0d5ccb23f6 by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 20/07/2022 at 23:04.
Pushed by apol into branch 'master'.

snap: Do not install a categories file

It doesn't bring us much anymore and it's confusing to our users.

M  +1    -2    libdiscover/backends/SnapBackend/CMakeLists.txt
D  +0    -15   libdiscover/backends/SnapBackend/snap-backend-categories.xml

https://invent.kde.org/plasma/discover/commit/6ce3ca31870e9d1d954f4437aeab4c0d5ccb23f6
Comment 4 Aleix Pol 2022-07-20 23:11:38 UTC
Git commit 5f08fb9a6702c50c6d91aa680c23694cca0b8ef9 by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 20/07/2022 at 23:11.
Pushed by apol into branch 'Plasma/5.25'.

snap: Do not install a categories file

It doesn't bring us much anymore and it's confusing to our users.


(cherry picked from commit 6ce3ca31870e9d1d954f4437aeab4c0d5ccb23f6)

M  +1    -2    libdiscover/backends/SnapBackend/CMakeLists.txt
D  +0    -15   libdiscover/backends/SnapBackend/snap-backend-categories.xml

https://invent.kde.org/plasma/discover/commit/5f08fb9a6702c50c6d91aa680c23694cca0b8ef9
Comment 5 Patrick Silva 2022-08-03 13:57:29 UTC
I'm still seeing 'Applications' instead of 'All Applications' after update to Plasma 5.25.4 on Arch Linux.
Comment 6 Nate Graham 2022-08-04 17:33:00 UTC
Is there a file named `snap-backend-categories.xml` anywhere on your machine? If so, delete it and see if that fixes it.
Comment 7 Patrick Silva 2022-08-04 22:29:06 UTC
I have renamed /usr/share/libdiscover/categories/snap-backend-categories.xml file. 'Applications' disappeared from the sidebar
instead of being renamed to 'All Applications'.
Comment 8 Nate Graham 2022-08-05 15:40:05 UTC
That was the intended change, from the MR, which I guess is not what you asked for! :D It looks like this file was sort of a leftover that only appeared for people not using the Snap backend due to another bug and implementing a proper "All Applications" item would take other work.

Can you file a bug report to ask for that, if it's something you think is important?
Comment 9 logicalwillow 2022-08-05 16:00:12 UTC
Isn't that the point of this bug report though?
Comment 10 Nate Graham 2022-08-05 16:03:48 UTC
Now that this bug report is closed, it makes sense to create a new one for the separate work. Bug reports are cheap and it usually works better to make them smaller and more granular.