| Summary: | heif decoding in 7.7.0 flatpak version not supported | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Paul Krause <paul_krause_1980> |
| Component: | Bundle-FlatPak | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | caulier.gilles, dnovomesky, metzpinguin, tjerksanberg+1iqvkbw8 |
| Priority: | NOR | ||
| Version First Reported In: | 7.7.0 | ||
| Target Milestone: | --- | ||
| Platform: | Flatpak | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | 7.9.0 | |
| Sentry Crash Report: | |||
|
Description
Paul Krause
2022-07-18 19:41:04 UTC
Please report this problem as DOWNSTREAM bug to the Flatpak team who maintain this bundle. https://github.com/flathub/org.kde.digikam/issues Best Gilles Caulier Paul, did you seen mu last comment about the libheif DOWNSTREAM bug ? Best Gilles Caulier Paul created the bug report and seems to be fixed as well. https://github.com/flathub/org.kde.digikam/issues/40 Maik Git commit 114bb696438d7beadbaf5e4441fc5dc486a14eb6 by Gilles Caulier. Committed on 26/07/2022 at 02:49. Pushed by cgilles into branch 'master'. use libheif from master to build flatpak bundle M +1 -1 project/bundles/flatpak/org.kde.digikam.json https://invent.kde.org/graphics/digikam/commit/114bb696438d7beadbaf5e4441fc5dc486a14eb6 Paul, The FlatPak bundle build by KDE binary factory infrastruture will use libheif code from git master with my last commit. But i suppose that your system use the FlatHub factory from GitHub : https://github.com/flathub/org.kde.digikam This one use libheif version 1.12.0 which do not include the fix: https://github.com/flathub/org.kde.digikam/blob/master/org.kde.digikam.json#L675 We don't manage these settings. Please report this kind of fix in your UPSTREAM bug : https://github.com/flathub/org.kde.digikam/issues/40 Best Gilles Caulier Dear Charles, Dear Mike, please apologize for not responding right away. First: The bug is not completely fixed at flathub. Heic (heif-container with h265 codec) files can be decoded, but avif files (heif-container with AV1 codec) still cannot be decoded. Even though libheif claims to be able, to decode avif images, at compile time (through libaom / dav1d). I thus suspect the problem to be at digikam, QT_LOGGING states 'digikam.dimg: "example.avif" Unknown image format !!!' and like to ask: A) Should this be handled at digikam, possibly in a new issue? B) If you have any idea, or help, how to investigate this, I would appreciate it. Second: Regarding comment #5, the flatpak manifest inside the digikam repository (project/bundles/flatpak/org.kde.digikam.json, the one linked) is the reason I reported here. I do not know if this manifest is important, but if: It has two problems. If the KDE binary factory builds originate from this manifest, then I can confirm both by testing with the latest build. A) It lacks libde265 and thus heic images are not decoded. Please see this commit for a fix: https://github.com/flathub/org.kde.digikam/pull/41/commits/fe223732b7f0157a980e663e9df9bc2698246b60 I do not think, that the commit in comment #4 should fix this. I think both flathub and this fix use the same libheif. B) It cannot decode avif images. As stated before, this is still not fixed at flathub. Thanks! & Best Paul Kruse AVIF image format is a supported image format in digiKam-7.7.0. It is provided by the QImage Loader. So the KImageFormat plugins must be compiled with AVIF and HEIF support. Maik PR by Novomeský, which adds support for AVIF (and JXL) in kimageformats Flatpak: https://invent.kde.org/packaging/flatpak-kde-runtime/-/merge_requests/104 Fixed downstream at flathub and with merge request !185 inside the digikam source, I close the issue. Thanks at all contributors. |