| Summary: | Pressing ESC key inside Spectacle's annotation mode inappropriately quits the app | ||
|---|---|---|---|
| Product: | [Applications] Spectacle | Reporter: | D3XT3R <tresdexter> |
| Component: | General | Assignee: | Antonio Prcela <antonio.prcela> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | antonio.prcela, kde, nate, nicolas.fella |
| Priority: | NOR | Keywords: | usability |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/spectacle/commit/37ee395ca0e1ef05febc82daa3a2ffb2431a65b5 | Version Fixed In: | 22.08 |
|
Description
D3XT3R
2022-07-17 14:57:57 UTC
Agreed. A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/147 as written in commit msg: "User's request is to only exit current tool in annotator. That'd be something upstream if I'm not mistaken. This does not solve the feature request 100%, instead it only improves the behaviour a bit." (In reply to Antonio Prcela from comment #3) > as written in commit msg: > > "User's request is to only exit current tool in annotator. > That'd be something upstream if I'm not mistaken. > This does not solve the feature request 100%, instead it only > improves the behaviour a bit." You are correct, this only lessens the loss. With the proposed solution, you didn't lose the screenshot, but I lost all the annotations made :( (In reply to D3XT3R from comment #4) > (In reply to Antonio Prcela from comment #3) > > as written in commit msg: > > > > "User's request is to only exit current tool in annotator. > > That'd be something upstream if I'm not mistaken. > > This does not solve the feature request 100%, instead it only > > improves the behaviour a bit." > > You are correct, this only lessens the loss. > With the proposed solution, you didn't lose the screenshot, but I lost all > the annotations made :( That seems to depend on your version of kImageannotator. Doesn't lose annotations on my end when i press ESC. kImageannotator version: 0.6.1 do: `ls /usr/lib/ | grep libkImage` and see what version number you got at, for example: libkImageAnnotator.so.0.6.1 iirc 0.6.0 is atm the latest one, i build 0.6.1 myself from source Git commit dd1d7baecd7a3d9356992151e57f1c380e9500c8 by Antonio Prcela. Committed on 26/07/2022 at 06:25. Pushed by aprcela into branch 'release/22.08'. using ESC while in annotation mode will close annotator instead of closing spectacle User's request is to only exit current tool in annotator. That'd be something upstream if I'm not mistaken. This does not solve the feature request 100%, instead it only improves the behaviour a bit. M +8 -0 src/Gui/KSMainWindow.cpp https://invent.kde.org/graphics/spectacle/commit/dd1d7baecd7a3d9356992151e57f1c380e9500c8 Git commit 37ee395ca0e1ef05febc82daa3a2ffb2431a65b5 by Antonio Prcela. Committed on 26/07/2022 at 06:28. Pushed by aprcela into branch 'master'. using ESC while in annotation mode will close annotator instead of closing spectacle User's request is to only exit current tool in annotator. That'd be something upstream if I'm not mistaken. This does not solve the feature request 100%, instead it only improves the behaviour a bit. (cherry picked from commit dd1d7baecd7a3d9356992151e57f1c380e9500c8) M +8 -0 src/Gui/KSMainWindow.cpp https://invent.kde.org/graphics/spectacle/commit/37ee395ca0e1ef05febc82daa3a2ffb2431a65b5 |