| Summary: | Importing certain JPEG-XL files crashes Krita (git master) | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | pdoce7781 |
| Component: | File formats | Assignee: | amyspark <amy> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | halla |
| Priority: | NOR | ||
| Version: | 5.1.0-beta1 | ||
| Target Milestone: | --- | ||
| Platform: | Appimage | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/8ee7309156660975d6608fc86e8e8fe14dc20815 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | An example jpeg-xl file that causes Krita 5.1.0-beta1 or higher to crash | ||
|
Description
pdoce7781
2022-07-15 03:11:33 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1523 Git commit 7aa65da676776951c26c3e42dd3d09da6781ed40 by Halla Rempt, on behalf of L. E. Segovia. Committed on 20/07/2022 at 07:40. Pushed by rempt into branch 'master'. JPEG XL: set the correct box buffer and size M +10 -6 plugins/impex/jxl/JPEGXLImport.cpp https://invent.kde.org/graphics/krita/commit/7aa65da676776951c26c3e42dd3d09da6781ed40 Git commit 3179ee41029f32138ef11c0720b848482a671782 by Halla Rempt, on behalf of L. E. Segovia. Committed on 20/07/2022 at 07:40. Pushed by rempt into branch 'master'. JPEG XL: fix stack overrun on box type checking M +14 -5 plugins/impex/jxl/JPEGXLImport.cpp https://invent.kde.org/graphics/krita/commit/3179ee41029f32138ef11c0720b848482a671782 Git commit 4a0b50d1663ce2453c6796bc8d6191a949506606 by Halla Rempt, on behalf of L. E. Segovia. Committed on 20/07/2022 at 07:40. Pushed by rempt into branch 'master'. JPEG XL: fix metadata application when the BASIC_INFO event hasn't fired yet Substance Designer exports images with metadata coming before the actual pixel stream. This makes it impossible to apply the metadata cleanly since we need an active image to create the paint layer. This commit fixes the issue by safekeeping the boxes and then applying them after the decode is finished. M +37 -21 plugins/impex/jxl/JPEGXLImport.cpp https://invent.kde.org/graphics/krita/commit/4a0b50d1663ce2453c6796bc8d6191a949506606 Git commit 4814025fbf701199596908928ffb37b8494794dd by L. E. Segovia. Committed on 20/07/2022 at 15:48. Pushed by lsegovia into branch 'krita/5.1'. JPEG XL: fix stack overrun on box type checking (cherry picked from commit 3179ee41029f32138ef11c0720b848482a671782) M +14 -5 plugins/impex/jxl/JPEGXLImport.cpp https://invent.kde.org/graphics/krita/commit/4814025fbf701199596908928ffb37b8494794dd Git commit 1d18ef1f3bdd615f0353124ce660da4954ce744c by L. E. Segovia. Committed on 20/07/2022 at 15:48. Pushed by lsegovia into branch 'krita/5.1'. JPEG XL: set the correct box buffer and size (cherry picked from commit 7aa65da676776951c26c3e42dd3d09da6781ed40) M +10 -6 plugins/impex/jxl/JPEGXLImport.cpp https://invent.kde.org/graphics/krita/commit/1d18ef1f3bdd615f0353124ce660da4954ce744c Git commit 8ee7309156660975d6608fc86e8e8fe14dc20815 by L. E. Segovia. Committed on 20/07/2022 at 15:48. Pushed by lsegovia into branch 'krita/5.1'. JPEG XL: fix metadata application when the BASIC_INFO event hasn't fired yet Substance Designer exports images with metadata coming before the actual pixel stream. This makes it impossible to apply the metadata cleanly since we need an active image to create the paint layer. This commit fixes the issue by safekeeping the boxes and then applying them after the decode is finished. (cherry picked from commit 4a0b50d1663ce2453c6796bc8d6191a949506606) M +37 -21 plugins/impex/jxl/JPEGXLImport.cpp https://invent.kde.org/graphics/krita/commit/8ee7309156660975d6608fc86e8e8fe14dc20815 |