Summary: | Color scheme previews pull disabled text and hovered button border colors from the active color scheme | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | Nagy Tibor <xnagytibor> |
Component: | kcm_colors | Assignee: | Janet Blackquill <uhhadd> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, nate, noahadvs, tantalising007, uhhadd |
Priority: | NOR | ||
Version: | 5.25.2 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/21905cfe068326ccc5763b373ec5e6c796f1586d | Version Fixed In: | 5.25.4 |
Sentry Crash Report: | |||
Attachments: | Screenshot |
lol can reproduce It seems like the problem is somewhere here: https://invent.kde.org/plasma/plasma-workspace/-/blob/master/kcms/colors/package/contents/ui/main.qml#L402 After a few tries, I can't figure out what it is though. Oops, this looks like it'll definitely be harder than it would initially seem to fix due to the nature of how we're passing colours to QML and how that interacts with modifier states like disabled and hovered. On it, though. Awesome, thanks! A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1927 Git commit 7a1c40672ccfc9827b2ebd278849bffbad87973d by Nate Graham, on behalf of Jan Blackquill. Committed on 22/07/2022 at 22:36. Pushed by ngraham into branch 'master'. kcms/colors: make sure the preview uses the right colours M +3 -0 kcms/colors/colorsmodel.cpp M +1 -0 kcms/colors/colorsmodel.h M +3 -0 kcms/colors/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/commit/7a1c40672ccfc9827b2ebd278849bffbad87973d Git commit 21905cfe068326ccc5763b373ec5e6c796f1586d by Nate Graham, on behalf of Jan Blackquill. Committed on 22/07/2022 at 23:42. Pushed by ngraham into branch 'Plasma/5.25'. kcms/colors: make sure the preview uses the right colours (cherry picked from commit 7a1c40672ccfc9827b2ebd278849bffbad87973d) M +3 -0 kcms/colors/colorsmodel.cpp M +1 -0 kcms/colors/colorsmodel.h M +3 -0 kcms/colors/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/commit/21905cfe068326ccc5763b373ec5e6c796f1586d |
Created attachment 150567 [details] Screenshot SUMMARY The color scheme previews at the Colors KCM are inaccurate. They pull the disabled text color and the hovered button border colors from the currently applied color scheme, not from their own. STEPS TO REPRODUCE 1. Open System Settings -> Appearance -> Global Theme -> Colors 2. Create a new color scheme where you change the following colors to something noticeable, for example radioactive green: - Common Colors -> Inactive Text - Common Colors -> Selection Background 3. Apply the modified theme OBSERVED RESULT See the attachment. EXPECTED RESULT Color previews should pull these colors from their own palette, not from the currently active color scheme. SOFTWARE/OS VERSIONS Operating System: KDE neon 5.25 KDE Plasma Version: 5.25.2 KDE Frameworks Version: 5.96.0 Qt Version: 5.15.5 Graphics Platform: X11