Bug 456593

Created attachment 150540 [details]
kdesrc-buildrc

Created attachment 150541 [details]
stderr and stdout of kdesrc-build command

Created attachment 150542 [details]
refresh build error?

Almost forgot, system requirements:

Operating System: Red Hat Enterprise Linux 9.0
KDE Plasma Version: 5.23.4
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.2
Kernel Version: 5.14.0-70.17.1.el9_0.x86_64 (64-bit)
Graphics Platform: Wayland

(system info I mean)

Alexander Lohnau over #kde-devel assisted me with this issue, plasma-wayland-protocols did not install at all, so kguiaddons wasn't able to find kde/usr/lib64/cmake/PlasmaWaylandProtocols/PlasmaWaylandProtocolsConfig.cmake. I had to cd to kde/build/plasma-wayland-protocols and run `ninja install` manually.

That it didn't install properly is clearly a bug, so I'm renaming this issue.

I'm not sure if this would be a kdesrc-build bug or a plasma-wayland-protocols bug.

Git commit 7e1a75e66d5b6ac4fc0db3e828d13728cd04f83c by Michael Pyne.
Committed on 14/07/2022 at 22:47.
Pushed by mpyne into branch 'master'.

buildsystem: Be more restrictive on when to skip install.

This fixes a bug where the documentation of how to force kdesrc-build to
proceed with the install "--refresh-build this module to force install"
did not match kdesrc-build's behavior.

But in addition this adds a check that the module was ever successfully
installed by checking for a matching persistent option.  I suspect this
might be part of the problem experienced by a user in bug 456593.

M  +6    -3    modules/ksb/Module.pm

https://invent.kde.org/sdk/kdesrc-build/commit/7e1a75e66d5b6ac4fc0db3e828d13728cd04f83c

This is fixed.

Git commit 3579712a31a61971319fb4028b94d873f2b38586 by Andrew Shark.
Committed on 19/09/2025 at 20:59.
Pushed by ashark into branch 'master'.

fix: Remove faulty optimization for skipping installation

In kdesrc-build, there was an attempt to add optimization for skipping
installation in case the ninja build tool "had no work to do" during
build. That feature was requested in https://invent.kde.org/sdk/kdesrc-build/-/issues/92.

This optimization was introduced by commit:
https://invent.kde.org/sdk/kdesrc-build/-/commit/8c693eeef39466bfd3dc3b7132b3200884236aa5

A new problem was that even with "--refresh-build", it was not possible
to bypass the unwanted "optimization" triggering.

Later, the check for presence of "--refresh-build" was added:
https://invent.kde.org/sdk/kdesrc-build/-/commit/7e1a75e66d5b6ac4fc0db3e828d13728cd04f83c

However, a problem still remained. Sometimes, users want to update some
project files, which do not affect "ninja work", and reinstall the
project. And user may not want to use the "--refresh-build", because
it is very expensive. See this issue:
https://invent.kde.org/sdk/kdesrc-build/-/issues/107

In kdesrc-build, the optimization was half-incorrectly disabled in
https://invent.kde.org/sdk/kdesrc-build/-/commit/fb7c8f06a082ec676798434cc33e8f7523f6bdab.
It was done by not allowing "work_done" variable be set to false
(except the bug when using --debug, which was fixed in kde-builder).

Also, there was a problem with making a decision if installation is needed,
depending on the presence of "last-install-rev" in persistent options.
This was not entirely correct. The user may have some local changes,
not yet committed (i.e. having the same install-revision number).
And this check forced user to skip reinstallation of the project.

So, there is no point in such "optimization". At least, with such implementation.
So remove it now.

M  +0    -15   kde_builder_lib/build_system/build_system.py
M  +1    -4    kde_builder_lib/module/module.py
M  +0    -1    kde_builder_lib/util/logged_subprocess.py

https://invent.kde.org/sdk/kde-builder/-/commit/3579712a31a61971319fb4028b94d873f2b38586