| Summary: | Alt Accelerators don't appear on buttons | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | David Chmelik <dchmelik> |
| Component: | kcm_lookandfeel | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | CONFIRMED --- | ||
| Severity: | minor | CC: | albayenes, aspotashev, bad63r, nate |
| Priority: | NOR | Keywords: | junior-jobs |
| Version First Reported In: | 5.25.2 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | screenvideo | ||
Works for me on all pages tested when I hold down the Alt key as well as when I use the Breeze style setting to make them always appear. Do the underlines appear when you hold down the Alt key? Doesn't work for me in Slackware64-current nor KDE Neon (up-to-date today and a few minutes ago.) Just in System Settings? Or in other KDE apps as well? Does it work if you use the Breeze application style? (In reply to Nate Graham from comment #3) > Just in System Settings? Or in other KDE apps as well? It's only about systemsettings: appearance: global theme (unless you notice anything else; I don't such as Konsole, Dolphin, KATE are fine.) > Does it work if you use the Breeze application style? No (on Slackware64-current but haven't tested Neon) though if it did, since I only switch between Air & Oxygen that wouldn't be a solution. > It's only about systemsettings: appearance: global theme
So only that page in System Settings? Any other ones?
(In reply to Nate Graham from comment #5) > > It's only about systemsettings: appearance: global theme > So only that page in System Settings? Any other ones? I tried to check all systemsettings (unsure was able because still are many (sub)levels, which is good) and didn't notice any more cases. Thanks can you take a screenshot of the Global Themes page while you have the Alt key held down so I can see which buttons are missing accelerators? You may need to use Spectacle's Delay feature to accomplish this. Created attachment 150683 [details]
screenvideo
no buttons have underlines
Thanks. Your video shows that the "Defaults" button has an underline. However it also shows that the "Get New Global Themes" button on the main page has no underlines, and none of the buttons in the "Apply" sheet do. There is QML Buttons on the form which is responsible for buttons
./kde/src/plasma-workspace/kcms/lookandfeel/package/contents/ui/main.qml:116
QtControls.Button {
id: proceedButton
text: i18n("Apply")
icon.name: "dialog-ok-apply"
onClicked: {
kcm.save()
globalThemeConfirmSheet.close()
view.forceActiveFocus() //Prevent further button presses via keyboard
}
enabled: kcm.appearanceToApply & Private.LookandFeelManager.AppearanceSettings ||
kcm.layoutToApply & Private.LookandFeelManager.LayoutSettings ||
kcm.layoutToApply & Private.LookandFeelManager.DesktopLayout
}
QML Button does not show underline of the text when the Alt key is pressed. Ampersand may be added before "Apply" to force the form in order to use <Alt>A as accelerator. But as I mentioned earlier, QML Button does not show underlines. I do not know why qt removed this feature. Maybe I am missing something.
So you suspect a bug in Qt, rather than our styling of Button controls in qqc2-desktop-style? Same problem in System Monitor (Plasma 5.27.10 on Debian-like). Hi all,
I have just checked:
--> Wayland (Plasma 6.1.80; KDE Frameworks Version: 6.7.0; Qt Version: 6.7.2;)
All working as expected. There is <ALT> shortcut for each button. Can't reproduce false behavior.
--> X11 ((Plasma 6.1.80; KDE Frameworks Version: 6.7.0; Qt Version: 6.7.2;)
Hi all,
I have just checked:
--> Wayland (Plasma 6.1.80; KDE Frameworks Version: 6.7.0; Qt Version: 6.7.2;)
All working as expected. There is <ALT> shortcut for each button. Can't reproduce false behavior.
--> X11 ((Plasma 6.1.80; KDE Frameworks Version: 6.7.0; Qt Version: 6.7.2;)
* There is false behavior as described (2. Go to settings such as appearance: global theme -> Get New theme Button is not reacting to <ALT> shortcut).
* System Monitor is not reacting to <ALT> shortcut for any button.
Do we plan to support X11 or focus more on Wayland? Maybe I would be interested in fixing this for X11, but I guess KDE will switch/is switched to Wayland now so is there a point?
|
SUMMARY Keystrokes don't exist to apply some settings. STEPS TO REPRODUCE 1. Run systemsettings. 2. Go to settings such as appearance: global theme (possibly/probably others: check all.) 3. Look for underlined letter to do <ALT><letter> keystroke (can't see any.) OBSERVED RESULT Keystrokes don't exist to apply some settings: global theme no longer has standard underlined letter buttons indicating <ALT><letter> keystrokes to 'apply' nor 'cancel' (though <ESC>) cancels) etc: mouse usage forced (if works.) EXPECTED RESULT Allow & process consistent standard underlined-letter button keystrokes ('apply' usually being <ALT>a or sometimes <ALT>p, <ALT>l, or <ALT>y but should be same/standardized/consistent for all cases (no menu uses those letters for other buttons) and include keystrokes for 'cancel' and all systemsettings buttons.) Don't assume touchscreen-only (no keyboard) PC! SOFTWARE/OS VERSIONS Linux/KDE Plasma: KDE Neon User 5.25.2 (up-to-date,) Slackware64 15.1-current (up-to-date ) / 5.25.2 KDE Plasma Version: 5.25.2 KDE Frameworks Version: 5.95.0 Qt Version: 5.15.5 (Neon,) 5.15.4 (Slackware)