Bug 456351

Summary: Beta 5.2 1 : Flashing line while using polygon tool / polygon selection / Multibrush (origin line)
Product: [Applications] krita Reporter: Postmax <medewerker1>
Component: Tools/SelectionAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: 1012468643, ahab.greybeard, griffinvalley, info
Priority: NOR Keywords: regression
Version: 5.1.0-beta1   
Target Milestone: ---   
Platform: macOS (DMG)   
OS: macOS   
Latest Commit: https://invent.kde.org/graphics/krita/commit/120a408b40ee1c12b42a700e76af097cdcdb66d1 Version Fixed In:
Sentry Crash Report:
Attachments: Another video capture of the glitch, on 5.2x today (for documentation/reference).

Description Postmax 2022-07-05 11:52:26 UTC 
In the new beta (5.2 v1) I noticed an issue with a green/white flickering line while using the polygon tool and the polygon selection tool. I am using an 2011 iMac with High Sierra installed. It is also present when using the multibrush tool (origin line flashes)

I have not noticed this in other tools yet.

Here is a screen capture:
https://recordit.co/ShhEw36gM7 8
Comment 1 Ahab Greybeard 2022-07-05 12:33:38 UTC 
Testing appimages with Debian 10, I can confirm these observations with the 5.1.0-beta1 and the Jul 3 5.2.0-prealpha (git 76a9e434dd).

This does not happen with version 5.0.6 hence regression wrt 5.0.6.

I see it happening with the following drawing tools: rectangle, ellipse, polygon, polyline, multibrush origin lines, move tool bounding box, polygonal selection and freehand selection.
The 'construction guide line' beomes green in parts or as a whole in a variable manner as the cursor moves around.
It does not happen with the rectangular selection or elliptical selection tools.
Comment 2 Postmax 2022-07-05 18:29:35 UTC 
(In reply to Postmax from comment #0)
> In the new beta (5.2 v1) I noticed an issue with a green/white flickering
> line while using the polygon tool and the polygon selection tool. I am using
> an 2011 iMac with High Sierra installed. It is also present when using the
> multibrush tool (origin line flashes)
> 
> I have not noticed this in other tools yet.
> 
> Here is a screen capture:
> https://recordit.co/ShhEw36gM7 8

To clarify: I meant Beta 5.1.0 v1
Comment 3 Deif Lou 2022-10-03 09:12:18 UTC 
*** Bug 456219 has been marked as a duplicate of this bug. ***
Comment 4 Deif Lou 2022-10-03 09:13:08 UTC 
*** Bug 459936 has been marked as a duplicate of this bug. ***
Comment 5 David REVOY 2022-10-17 12:21:12 UTC 
Created attachment 152937 [details]
Another video capture of the glitch, on 5.2x today (for documentation/reference).
Comment 6 wolthera 2023-01-18 12:57:32 UTC 
I can reproduce here on my local build with qt 5.15.6, gonna assign it to Dmitry as per his request.
Comment 7 Dmitry Kazakov 2023-01-19 08:37:15 UTC 
Git commit 120a408b40ee1c12b42a700e76af097cdcdb66d1 by Dmitry Kazakov.
Committed on 19/01/2023 at 08:37.
Pushed by dkazakov into branch 'master'.

Fix flickering in Outline Selection tool

When painting the outline we paint it in native mode, not using
QPainter. Therefore we should care about clipping manually.

M  +11   -1    libs/ui/opengl/KisOpenGLCanvasRenderer.cpp
M  +1    -1    libs/ui/opengl/KisOpenGLCanvasRenderer.h
M  +10   -1    libs/ui/opengl/kis_opengl_canvas2.cpp

https://invent.kde.org/graphics/krita/commit/120a408b40ee1c12b42a700e76af097cdcdb66d1