Bug 456321

*** This bug has been marked as a duplicate of bug 455395 ***

So this is not resolved/fixed in 5.25.3. Inactive titlebar is still not colored when the corresponding option is checked. 

This was marked as dublicate of https://bugs.kde.org/show_bug.cgi?id=455395 whichs says it's fixed in 5.25.3. So is this a separate issue or am I missing something?

I'm reopening this as it's not fixed in Plasma 5.25.3. Repro instructions in original bug report.

Can you attach a screenshot that shows an active window and an inactive window, with both using your custom color scheme?

Created attachment 150743 [details]
inactive titlebar color

Ive attached it above. The color scheme is copy of Breeze Light, I renamed it Breeze Light Alt, applied the color settings to it and saved, then hit apply.

And if I uncheck the inactive titlebar color setting, save and apply, the tiltebar color look exactly the same, which is why I think the feature is not workin?

https://imgur.com/JuzKiu0

Thanks. Cannot reproduce in current git master. Can you attach your custom color scheme file?

Created attachment 150747 [details]
Breeze Light color scheme with custom accent settings

Can reproduce with that color scheme file.

This appears to be a config migration/sync issue. I can make your color scheme work for me by applying the following changes:

nate@Liberator:~/Desktop$  diff OLD.colors NEW.colors 
134,138c134,136
< TintFactor=0.15
< accentActiveTitlebar=true
< accentInactiveTitlebar=true
---
> TitlebarIsAccentColored=true

So this is already fixed in git master, but 5.25.x is broken, because we have a mismatch between the config data name and what the UI shows.

Thank you for taking this under scrutiny!

(In reply to Nate Graham from comment #11)
> This appears to be a config migration/sync issue. I can make your color
> scheme work for me by applying the following changes:
> 
> nate@Liberator:~/Desktop$  diff OLD.colors NEW.colors 
> 134,138c134,136
> < TintFactor=0.15
> < accentActiveTitlebar=true
> < accentInactiveTitlebar=true
> ---
> > TitlebarIsAccentColored=true
> 
> So this is already fixed in git master, but 5.25.x is broken, because we
> have a mismatch between the config data name and what the UI shows.

This bug is still present on Plasma 5.25.5. On test images of KDE Neon, with Plasma 5.26 beta, the option to tint inactive headers doesn't exist anymore. Won't we have this option anymore?

It was removed because now we always tint inactive headers when using this setting.

(In reply to Nate Graham from comment #14)
> It was removed because now we always tint inactive headers when using this
> setting.

So, it should be working here, right?
https://i.imgur.com/pyHGnq3.png
https://i.imgur.com/A7eWDNx.png
But it is not applying to Dolphin, in this example, a inactive app.
I tested with the neon-unstable-20220922-0959 image.

Can you please attach your custom .colors file that I can use to reproduce the issue?

Created attachment 152444 [details]
Custom-Colorscheme-Plasma-5.26.80

This is the color scheme. I just selected Breeze, tick the checkbox to tint headers and the window and increase a little the tint strength.

(In reply to Nate Graham from comment #16)
> Can you please attach your custom .colors file that I can use to reproduce
> the issue?

Done.

Thanks. Seems to me that it's working; the inactive titlebar gets tinted with the accent color just like you told it to. However because you also told it to tint all other colors with the accent color too, this becomes no longer noticeable in comparison to the other colors. But it's still getting tinted.

(In reply to Nate Graham from comment #19)
> Thanks. Seems to me that it's working; the inactive titlebar gets tinted
> with the accent color just like you told it to. However because you also
> told it to tint all other colors with the accent color too, this becomes no
> longer noticeable in comparison to the other colors. But it's still getting
> tinted.

Oh, so there is no more the option to the inactive titlebar gets tinted exactly as the active titlebar? I mean, with the strong color.
I will attach a screenshot on how it used to be.

Created attachment 152468 [details]
old-way-to-tint-inactive-titlebars

So, there is no way to get this behavior again, right?

That's correct. This was done intentionally as a way of making it harder for people to accidentally create color schemes with no visual contrast between active and inactive windows.

Created attachment 152542 [details]
CustomColorSchemeWithTintTitlebar

Ok, I'm here again. Sorry for that.

I want to know if this is the desired behavior:
The default Breeze Light and Dark have this behavior that we see in the beginning of the video - the titlebar of the inactive widow has a different contrast to differentiate.
So, when we use the option to tint the header based on these two color scheme, this effect happens. Ok. It's expected.
But, if we create a custom color scheme with a custom header (that doesn't change the contrast from inactive windows - as you also see in the video) and them enable the option to tint the titlebar on this color scheme, it change it behavior. Without this option the contrast don't change so, I was hoping that, after enable this option to this specific color scheme, the contrast doesn't change too.

Is this the expected behavior? To always do this, independent of the color scheme, of the user option and everything else? When you active the option to tint the titlebar it will always change the contrast of the inactive window and there is nothing that we can do?