| Summary: | Enclose-and-fill tool: Take image border into account | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | tomtomtomreportingin |
| Component: | Usability | Assignee: | Deif Lou <ginoba> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | ginoba |
| Priority: | NOR | ||
| Version: | 5.1.0-beta1 | ||
| Target Milestone: | --- | ||
| Platform: | Appimage | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/c111c9f7765e432da792176271a716b8475483c5 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
tomtomtomreportingin
2022-07-04 01:54:56 UTC
Yes, I didn't forget about that, and I agree with what you say. It's just that I haven't got much time lately. The only practical case I can think of is when using the "wrap around mode", but since the "enclose and fill" uses the "floodfill" algorithm (which the "fill tool" uses as well), and it is not "wrap around mode" aware, I think we can skip that for now. A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1506 Git commit 60b0d351cd5e2cb820ebd844c146d3a3644ff66c by Deif Lou. Committed on 07/07/2022 at 14:34. Pushed by deiflou into branch 'master'. Make the enclose and fill tool take into account canvas limits. Now, when the wrap around mode is not active, the canvas border is taken as another limit when finding the regions M +52 -19 libs/image/KisEncloseAndFillPainter.cpp M +3 -3 libs/image/KisEncloseAndFillPainter.h M +1 -3 libs/ui/processing/KisEncloseAndFillProcessingVisitor.cpp https://invent.kde.org/graphics/krita/commit/60b0d351cd5e2cb820ebd844c146d3a3644ff66c Git commit c111c9f7765e432da792176271a716b8475483c5 by Deif Lou. Committed on 07/07/2022 at 15:02. Pushed by deiflou into branch 'krita/5.1'. Make the enclose and fill tool take into account canvas limits. Now, when the wrap around mode is not active, the canvas border is taken as another limit when finding the regions M +52 -19 libs/image/KisEncloseAndFillPainter.cpp M +3 -3 libs/image/KisEncloseAndFillPainter.h M +1 -3 libs/ui/processing/KisEncloseAndFillProcessingVisitor.cpp https://invent.kde.org/graphics/krita/commit/c111c9f7765e432da792176271a716b8475483c5 |