Bug 456236

Summary: Okular doesn't respect signature notification settings
Product: [Applications] okular Reporter: inoigt2048
Component: generalAssignee: Okular developers <okular-devel>
Status: RESOLVED NOT A BUG    
Severity: normal CC: aacid
Priority: NOR    
Version First Reported In: 22.04.2   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description inoigt2048 2022-07-02 11:24:46 UTC 
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1.  Launch a signed document in okular
2.  Ensure "Notify about embedded files, forms, or signatures" is disabled in the settings
3.  Annotate the PDF by highlighting a piece of text
4.  Save the PDF

OBSERVED RESULT
A popup saying "This document is digitally signed, There have been changes since last signed" will appear, closing this popup and saving the file again will cause the popup to appear again

EXPECTED RESULT
No popup should have appeared considering all notifications about signatures and forms were disabled in step 2

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 5.18.5-arch1-1
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 5.15.5

ADDITIONAL INFORMATION
Comment 1 Albert Astals Cid 2022-07-03 22:46:44 UTC 
That warning is there for your security, you don't really want to disable it.

You need to be warned that a file that is signed and says "YOU ARE FIRED" but has been modified since it was signed may not really mean you're fired.
Comment 2 inoigt2048 2022-07-04 02:51:11 UTC 
(In reply to Albert Astals Cid from comment #1)
> That warning is there for your security, you don't really want to disable it.
> 
> You need to be warned that a file that is signed and says "YOU ARE FIRED"
> but has been modified since it was signed may not really mean you're fired.

I mean the point of the option is to disable the popup, so it really should do the thing whether or not it's a security feature. I originally came here from a [reddit thread](https://www.reddit.com/r/kde/comments/q4e8n9/comment/hfz5e7t/) where another contributor said to report this here
Comment 3 Albert Astals Cid 2022-07-04 17:46:10 UTC 
> I mean the point of the option is to disable the popup

No, the point of the option is to disable the one that says "there's a signature" not the one that says "there's a signature and this PDF should not be trusted, run away".