Bug 456180

Summary:	leftmost column in Status and Notifications has its focus highlight rendered on top
Product:	[Plasma] plasmashell	Reporter:	nttkde <watisthispoo>
Component:	System Tray widget	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	materka, nate
Priority:	NOR
Version First Reported In:	5.25.2
Target Milestone:	1.0
Platform:	Neon
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/commit/0ae0fbecf223c55bc6c713dbc504acb0e5927194	Version Fixed/Implemented In:	5.27.6
Sentry Crash Report:
Attachments:	highlighted leftmost column items are bluer

Description nttkde 2022-06-30 17:40:17 UTC

Created attachment 150301 [details]
highlighted leftmost column items are bluer

This has to be the most subtle bug I've reported so far :P

In the Status and Notifications (is it called HiddenItemsView) popup, the translucent focus highlight is drawn on top of items in the leftmost column. Items in other columns have the highlight correctly behind the icon and caption.

It's kinda really difficult to see with Light Breeze Plasma theme but is more visible in Dark theme.

....
Disclaimer: I didn't go through the code nor know how it works, but I think I might have found some kind of clue. 

plasma-workspace/applets/systemtray/package/contents/ui/items/ItemLoader.qml sets z = x which I'm just guessing affects the items' z ?   (Looks like it's to make tab key navigation order work correctly; explained here: https://github.com/KDE/plasma-workspace/commit/73d13d1bfee620c76709ea39a9b7948323887059).

So perhaps that results in leftmost items with small x getting z that is not bigger than the highlight's z ? (or something) 

I may be entirely wrong in my reasoning, of course, but setting z = x+1 seems to fix the appearance, so at least it seems to be somehow related.

KDE Neon User, Plasma 5.25.2

Comment 1 Nate Graham 2022-07-01 13:48:31 UTC

Great investigation. Can confirm, and it seems like you found the exact cause of it, indeed. Can you submit a merge request with your proposed fix (which seems reasonable to me given the current architecture) at https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/? Thanks!

Comment 2 Nate Graham 2023-05-17 19:40:20 UTC

Git commit 4d828b1b28e0bb0ecf7209764539b1099ae3a328 by Nate Graham.
Committed on 17/05/2023 at 19:38.
Pushed by ngraham into branch 'master'.

applets/systemtray: fix highlight being on top of first column items

By binding the content item's z to its x value, the first column where
x is 0 was being drawn underneath the highlight effect.
FIXED-IN: 5.27.6

co-authored-by: nttkde <watisthispoo@outlook.com>

M  +1    -1    applets/systemtray/package/contents/ui/items/ItemLoader.qml

https://invent.kde.org/plasma/plasma-workspace/commit/4d828b1b28e0bb0ecf7209764539b1099ae3a328

Comment 3 Nate Graham 2023-05-17 19:41:06 UTC

Git commit 0ae0fbecf223c55bc6c713dbc504acb0e5927194 by Nate Graham.
Committed on 17/05/2023 at 19:40.
Pushed by ngraham into branch 'Plasma/5.27'.

applets/systemtray: fix highlight being on top of first column items

By binding the content item's z to its x value, the first column where
x is 0 was being drawn underneath the highlight effect.
FIXED-IN: 5.27.6

co-authored-by: nttkde <watisthispoo@outlook.com>
(cherry picked from commit 4d828b1b28e0bb0ecf7209764539b1099ae3a328)

M  +1    -1    applets/systemtray/package/contents/ui/items/ItemLoader.qml

https://invent.kde.org/plasma/plasma-workspace/commit/0ae0fbecf223c55bc6c713dbc504acb0e5927194