Bug 456155

Summary:	New version for KWIN_EFFECT_API_VERSION?
Product:	[Plasma] kwin	Reporter:	Matin Lotfaliei <matinlotfali>
Component:	compatibility	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	crash	CC:	matinlotfali, nate
Priority:	NOR
Version First Reported In:	git master
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/kwin/commit/1ee1e011a3b6ca1d0d3bea7a7b1c07bb14c08356	Version Fixed In:
Sentry Crash Report:

Description Matin Lotfaliei 2022-06-30 05:22:30 UTC

I noticed in **KDE Neon Unstable** that `ShaderManager::generateShaderFromFile` function in `kwinglutils.h` is now returning `std::unique_ptr` instead of a raw pointer. This is a very good thing!

But the `KWIN_EFFECT_API_VERSION` is still **234**. Shouldn't the version be updated to **235** as well with every change in the header file?
I mean how else can I have a code that runs on both the Stable and Unstable versions of KDE Neon?

Comment 1 Bug Janitor Service 2022-06-30 20:13:30 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/2597

Comment 2 Zamundaaa 2022-06-30 20:46:40 UTC

Git commit 1ee1e011a3b6ca1d0d3bea7a7b1c07bb14c08356 by Xaver Hugl, on behalf of Alexander Lohnau.
Committed on 30/06/2022 at 20:25.
Pushed by zamundaaa into branch 'master'.

Bump KWIn effects API version after changes to smart pointers in public API

M  +1    -1    src/libkwineffects/kwineffects.h

https://invent.kde.org/plasma/kwin/commit/1ee1e011a3b6ca1d0d3bea7a7b1c07bb14c08356