Summary: | Tooltip for the new big buttons closes immediately if hovering same button again | ||
---|---|---|---|
Product: | [Applications] Discover | Reporter: | nttkde <watisthispoo> |
Component: | discover | Assignee: | Nate Graham <nate> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | aleixpol, nate |
Priority: | NOR | ||
Version: | 5.25.2 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/discover/commit/71623684d6d638481eb007e0e9ee8e54c9ae0274 | Version Fixed In: | 5.25.3 |
Attachments: | video |
Urgh, can reproduce. Probably an issue with the shared ToolTip instance. We could instantiate a new one per button, at the cost of some memory. A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/326 Git commit 24d3c665c733ece4cd4a0414d6b70b602e0a81a6 by Nate Graham. Committed on 04/07/2022 at 00:45. Pushed by ngraham into branch 'master'. ApplicationResourceButton: switch to individual ToolTip instances We currently use a shared tooltip ostensibly to save memory, but the shared opening/closing conditions cause the tooltips to close too early when the cursor has hovered over more then one button by the time it comes to rest on a different one. To fix around this in the simplest way, let's switch to give each button a unique ToolTip instance. In testing, there is no appreciable increase in memory usage. FIXED-IN: 5.25.3 M +3 -4 discover/qml/ApplicationResourceButton.qml https://invent.kde.org/plasma/discover/commit/24d3c665c733ece4cd4a0414d6b70b602e0a81a6 Git commit 71623684d6d638481eb007e0e9ee8e54c9ae0274 by Nate Graham. Committed on 04/07/2022 at 00:52. Pushed by ngraham into branch 'Plasma/5.25'. ApplicationResourceButton: switch to individual ToolTip instances We currently use a shared tooltip ostensibly to save memory, but the shared opening/closing conditions cause the tooltips to close too early when the cursor has hovered over more then one button by the time it comes to rest on a different one. To fix around this in the simplest way, let's switch to give each button a unique ToolTip instance. In testing, there is no appreciable increase in memory usage. FIXED-IN: 5.25.3 (cherry picked from commit 24d3c665c733ece4cd4a0414d6b70b602e0a81a6) M +3 -4 discover/qml/ApplicationResourceButton.qml https://invent.kde.org/plasma/discover/commit/71623684d6d638481eb007e0e9ee8e54c9ae0274 |
Created attachment 150262 [details] video Tooltip for the new big 'Documentation/Website/Donate/Report a bug' buttons (eg. on Krita's app page) closes immediately if the previously focused button (within those 4) was the same one. See the attached video KDE Neon User Plasma 5.25.2 X11