| Summary: | Networks widget does not reveal correct mac after mac spoofing | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Ilab Sentuser <ilabsentuser> |
| Component: | Networks widget | Assignee: | Jan Grulich <jgrulich> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-nm/commit/758c651a29adc64d77c0c6c2eb018b0119b0f16f | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Ilab Sentuser
2022-06-29 11:14:24 UTC
I was curious and went and checked the source code. It does not appear a bug though, rather made that way intentionally so it should be requested as a feature instead. At least it seems that way by looking at the git code: wifiSetting->setMacAddress(NetworkManager::macAddressFromString(wifiDev->permanentHardwareAddress())); In file: https://github.com/KDE/plasma-nm/blob/master/kcm/kcm.cpp I am not sure if this should be a request or a bug, as it seems intentional but also is a bit counterintuitive. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/148 Git commit 7908728eb34c4311b2a2ae9b17e5cdba9f587c18 by Nicolas Fella, on behalf of Ilab Sentuser. Committed on 11/11/2022 at 16:23. Pushed by nicolasfella into branch 'master'. Show current MAC address instead of permanent MAC address in details view Current behavior is for the details view to show the permanent MAC address of the card. This currently creates a missunderstanding in which the user might think that the MAC address in use is, in fact, the one shown there, while this might not be the case if the MAC addres has been cloned/changed/spoofed. This leads the user to believe that the change to his MAC address did not work or to not be able to recognize his own traffic if he expect to see that MAC on sniffed traffic for example, and many other scenarios. NOTE: the current fix is applied only to the wireless device as it I am unable to test the wired device code block and would refrain from committing untested code, but it is highly advisable to add those too. M +1 -1 libs/models/networkmodelitem.cpp https://invent.kde.org/plasma/plasma-nm/commit/7908728eb34c4311b2a2ae9b17e5cdba9f587c18 Git commit 758c651a29adc64d77c0c6c2eb018b0119b0f16f by Nicolas Fella, on behalf of Ilab Sentuser. Committed on 11/11/2022 at 16:25. Pushed by nicolasfella into branch 'Plasma/5.26'. Show current MAC address instead of permanent MAC address in details view Current behavior is for the details view to show the permanent MAC address of the card. This currently creates a missunderstanding in which the user might think that the MAC address in use is, in fact, the one shown there, while this might not be the case if the MAC addres has been cloned/changed/spoofed. This leads the user to believe that the change to his MAC address did not work or to not be able to recognize his own traffic if he expect to see that MAC on sniffed traffic for example, and many other scenarios. NOTE: the current fix is applied only to the wireless device as it I am unable to test the wired device code block and would refrain from committing untested code, but it is highly advisable to add those too. (cherry picked from commit 7908728eb34c4311b2a2ae9b17e5cdba9f587c18) M +1 -1 libs/models/networkmodelitem.cpp https://invent.kde.org/plasma/plasma-nm/commit/758c651a29adc64d77c0c6c2eb018b0119b0f16f Git commit e109d436a17bf009a050dbe003ecd50d59c2a5de by Nicolas Fella. Committed on 11/11/2022 at 16:27. Pushed by nicolasfella into branch 'master'. Show current MAC for wired connections Like we do for wireless connections already M +1 -1 libs/models/networkmodelitem.cpp https://invent.kde.org/plasma/plasma-nm/commit/e109d436a17bf009a050dbe003ecd50d59c2a5de Git commit 7dc3b4adae3964c104855b24e9700c3a49b69793 by Nicolas Fella. Committed on 11/11/2022 at 16:28. Pushed by nicolasfella into branch 'Plasma/5.26'. Show current MAC for wired connections Like we do for wireless connections already (cherry picked from commit e109d436a17bf009a050dbe003ecd50d59c2a5de) M +1 -1 libs/models/networkmodelitem.cpp https://invent.kde.org/plasma/plasma-nm/commit/7dc3b4adae3964c104855b24e9700c3a49b69793 Bulk transfer as requested in T17796 |