Bug 456038

Summary:	Accent Colour detection done unnecessarily when the sync is disabled / for non primary screens.
Product:	[Plasma] plasmashell	Reporter:	David Edmundson <kde>
Component:	Image & Slideshow wallpaper plugins	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	nate, notmart, qydwhotmail
Priority:	NOR	Keywords:	regression
Version First Reported In:	5.25.0
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-desktop/commit/bfbc2973cc9d5b52fd96b05c10ff3ebc4f0d4794	Version Fixed/Implemented In:	5.26
Sentry Crash Report:

Description David Edmundson 2022-06-27 14:21:59 UTC

Kirigami.ImageColors is super expensive. It has to render the wallpaper twice into an offscreen texture, resize that, then go through pixels.

On my regular desktop machine over 3.5% of all startup, albeit some offloaded in another thread. That's fine when it's used. It's silly to do this when the feature is disabled / for non-primary screens and we throw the result away.

Could we have a think about some ideas for that.

Comment 1 Bug Janitor Service 2022-06-27 16:13:17 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1873

Comment 2 Bug Janitor Service 2022-06-27 16:13:37 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1008

Comment 3 Fushan Wen 2022-06-30 14:22:03 UTC

Git commit 523936395d0f0ea6ce9ec5c0463e4249ce89136d by Fushan Wen.
Committed on 30/06/2022 at 13:59.
Pushed by fusionfuture into branch 'master'.

shell: add new property `usedInAccentColor`

It will be used to indicate whether the desktop is used in accent color
extraction.

M  +60   -7    shell/desktopview.cpp
M  +20   -0    shell/desktopview.h
M  +21   -5    shell/shellcorona.cpp
M  +11   -0    shell/shellcorona.h

https://invent.kde.org/plasma/plasma-workspace/commit/523936395d0f0ea6ce9ec5c0463e4249ce89136d

Comment 4 Fushan Wen 2022-06-30 14:24:56 UTC

Git commit bfbc2973cc9d5b52fd96b05c10ff3ebc4f0d4794 by Fushan Wen.
Committed on 30/06/2022 at 14:01.
Pushed by fusionfuture into branch 'master'.

desktoppackage: load accent color extractor on demand
FIXED-IN: 5.26

M  +23   -13   desktoppackage/contents/views/Desktop.qml

https://invent.kde.org/plasma/plasma-desktop/commit/bfbc2973cc9d5b52fd96b05c10ff3ebc4f0d4794