| Summary: | ksambashare.cpp -- parse() fails on output of "net usershare info" | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Claus-Justus Heine <himself> |
| Component: | general | Assignee: | KIO Bugs <kio-bugs-null> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | asturm, christoph, kdelibs-bugs-null, nate |
| Priority: | NOR | ||
| Version First Reported In: | 5.95.0 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Patch to remove trailing comma of "net usershare info" output | ||
I'm not sure this isn't something only to be fixed in samba then... ...but, if you want your patch to get looked at, create an MR over at https://invent.kde.org/frameworks/kio instead. Could one check if that still happens with recent samba versions or if that was just a temporary regression? 🐛🧹 ⚠️ This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information, then set the bug status to REPORTED. If there is no change for at least 30 days, it will be automatically closed as RESOLVED WORKSFORME. For more information about our bug triaging procedures, please read https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging. Thank you for helping us make KDE software even better for everyone! 🐛🧹 This bug has been in NEEDSINFO status with no change for at least 30 days. Closing as RESOLVED WORKSFORME. |
Created attachment 150167 [details] Patch to remove trailing comma of "net usershare info" output SUMMARY At least Samba version >=4.14.12 and <=4.16.2 generate a trailing comma with "net usershare info" like so: claus@anaxagoras /usr/local/storage/a/samba/public $ net usershare info [scanbox] usershare_acl=ANAXAGORAS\claus:R,Everyone:R,ANAXAGORAS\scanner-upload:F, OTOH, "net usershare add" does not accept a trailing comma as input and generates an error message: net usershare add: malformed acl (missing ':'). STEPS TO REPRODUCE 1. Use the sharing dialog for some local file with an existing share 2. Do something which triggers an error (e.g. use an unsupported user-name like "foo-bar", see #455956 ) 3. Try to apply the changes. The error messages of e.g. Dolphin will show something like "malformed acl (missing ':')." and the ACLs are also not updated. OBSERVED RESULT Saving ACLs fails. EXPECTED RESULT Saving ACLs works. SOFTWARE/OS VERSIONS Linux/KDE Plasma: Gentoo / X11 KDE Plasma Version: 5.25.1 KDE Frameworks Version: 5.95.0 Qt Version: 5.18.6 ADDITIONAL INFORMATION The bug is still present in the master branch.