Bug 455788

Summary:	pausemusic plugin has hard dependency on KF5PulseAudioQt, rendering it unusable on systems without PulseAudio
Product:	[Applications] kdeconnect	Reporter:	tmp6154
Component:	common	Assignee:	Albert Vaca Cintora <albertvaka>
Status:	CONFIRMED ---
Severity:	normal	CC:	tmp6154
Priority:	NOR
Version First Reported In:	22.04.2
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Patch to workaround this on Gentoo

Description tmp6154 2022-06-22 13:28:58 UTC

SUMMARY
On Gentoo, it's pretty common to build ALSA-only installation. pausemusic plugin supports muting system volume (via PulseAudio), and for that purpose it's hard depends on KF5PulseAudioQt. However, I'm interested only in pausing functionality through MPRIS, without muting system volume and my installation has no PulseAudio, so pausemusic plugin won't even build. I guess it's possible making muting support conditional if PulseAudioQt is missing, so that it's still possible to use pause functionality of plugin.


STEPS TO REPRODUCE
1. Compile kdeconnect on PulseAudio-less system.

OBSERVED RESULT

pausemusic plugin is missing.

EXPECTED RESULT

pausemusic plugin is compiled (without muting functionality).

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Gentoo Linux 2.8
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.4

Comment 1 tmp6154 2022-06-22 15:03:59 UTC

Created attachment 150055 [details]
Patch to workaround this on Gentoo

I've managed to remove muting support (together with PulseAudioQT dependency) pretty easily from plugin's code as a workaround and compile a working pausemusic plugin. I've attached a patch in case anyone will find it useful. So it should be pretty easy to make muting support optional by adding a couple of ifdefs here and there. Although I'm not sure how to deal with conditional stuff in UI code (QML), etc.

Comment 2 Albert Vaca Cintora 2023-03-23 17:24:17 UTC

We could make the pausemusic plugin still build without pulseaudio by disabling only the muting feature and not the whole plugin, but I don't think there's enough demand for this.

Comment 3 Albert Vaca Cintora 2023-03-23 17:24:56 UTC

If you want to submit a patch for that, it's welcome though ;)