Summary: | In the Android version, switching the style to Android caused a crash. | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Eranthis stellata Maxim <1012468643> |
Component: | * Unknown | Assignee: | sh_zam <shzam> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | shzam |
Priority: | NOR | ||
Version: | nightly build (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Other | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/0e9925407d912b5e776ce874b9bd396852feab50 | Version Fixed In: |
Description
Eranthis stellata Maxim
2022-06-20 17:12:36 UTC
I think the best solution would be to just disable this style since it looks very odd (i.e when it doesn't crash: https://photos.app.goo.gl/qXQTTGcUvv93PCFL8). What do you think Halla? Maybe something like this: From 251473543485b4137290d964f347dd35d8450656 Mon Sep 17 00:00:00 2001 From: Sharaf Zaman <shzam@sdf.org> Date: Sat, 6 Aug 2022 15:49:00 +0000 Subject: [PATCH] Android: Disable "android" style since it crashes ... and it looks disproportionate when it does work. BUG:455662 --- libs/ui/KisMainWindow.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libs/ui/KisMainWindow.cpp b/libs/ui/KisMainWindow.cpp index b69710c467..2a40c66807 100644 --- a/libs/ui/KisMainWindow.cpp +++ b/libs/ui/KisMainWindow.cpp @@ -398,6 +398,12 @@ KisMainWindow::KisMainWindow(QUuid uuid) d->styleActions = new QActionGroup(this); QAction * action; Q_FOREACH (QString styleName, QStyleFactory::keys()) { +#ifdef Q_OS_ANDROID + // disable the style for android platform + if (styleName.contains("android")) { + continue; + } +#endif action = new QAction(styleName, d->styleActions); action->setCheckable(true); d->actionMap.insert(styleName, action); -- 2.37.1 Git commit 5837e83c01ddbd91db0f808a32f3b2cb95c5caca by Sharaf Zaman. Committed on 09/08/2022 at 05:56. Pushed by szaman into branch 'master'. Android: Disable "android" style since it crashes ... and it looks disproportionate when it does work. M +6 -0 libs/ui/KisMainWindow.cpp https://invent.kde.org/graphics/krita/commit/5837e83c01ddbd91db0f808a32f3b2cb95c5caca Git commit 0e9925407d912b5e776ce874b9bd396852feab50 by Sharaf Zaman. Committed on 09/08/2022 at 07:42. Pushed by szaman into branch 'krita/5.1'. Android: Disable "android" style since it crashes ... and it looks disproportionate when it does work. (cherry picked from commit 5837e83c01ddbd91db0f808a32f3b2cb95c5caca) M +6 -0 libs/ui/KisMainWindow.cpp https://invent.kde.org/graphics/krita/commit/0e9925407d912b5e776ce874b9bd396852feab50 |