Bug 455613

Summary: "GetAppState called: no parameters" appears a lot in the journal
Product: [Plasma] xdg-desktop-portal-kde Reporter: cantabile <cantabile.desu>
Component: generalAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: aleixpol, jgrulich, nate, sitter
Priority: NOR    
Version First Reported In: 5.24.5   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description cantabile 2022-06-19 14:45:57 UTC
SUMMARY
There are lots of messages like this in the journal:

Jun 19 16:57:27 home xdg-desktop-portal-kde[1057]: xdp-kde-background: GetAppState called: no parameters
Jun 19 16:57:57 home xdg-desktop-portal-kde[1057]: xdp-kde-background: GetAppState called: no parameters
Jun 19 16:58:27 home xdg-desktop-portal-kde[1057]: xdp-kde-background: GetAppState called: no parameters

% sudo journalctl -b | grep --count GetAppState
407
% sudo journalctl -b | grep --count xdp-kde-background
407
(Booted yesterday, hibernated overnight.)

I see these are generated with qCDebug(XdgDesktopPortalKdeBackground). Does this debug category have to be enabled by default?


STEPS TO REPRODUCE
1. Use Plasma.
2. It might have to do with Firefox started with "GTK_USE_PORTAL=1".
3. 

OBSERVED RESULT
Useless messages in the journal.

EXPECTED RESULT
Fewer useless messages in the journal.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux.
KDE Plasma Version: 5.24.5.
KDE Frameworks Version: 5.94.0.
Qt Version: 5.15.4.

ADDITIONAL INFORMATION
I've been trying various things to see if they help with a wifi problem, which requires looking at the journal a lot. These messages get in the way.
Comment 1 Harald Sitter 2022-06-19 16:30:08 UTC
@Jan is there a reason we don't use the ecm macros to generate the categories?
Comment 2 Jan Grulich 2022-06-20 06:20:26 UTC
(In reply to Harald Sitter from comment #1)
> @Jan is there a reason we don't use the ecm macros to generate the
> categories?

I wasn't aware such macros exist. I can look into this later.
Comment 3 Harald Sitter 2022-06-20 07:31:44 UTC
No worries, I can make an MR, just wanted to check.
Comment 4 Bug Janitor Service 2022-06-20 07:40:55 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/113
Comment 5 Harald Sitter 2022-06-20 08:37:45 UTC
Git commit fe4d331e85468e67ce07fb3facb51fe04545cd57 by Harald Sitter.
Committed on 20/06/2022 at 07:44.
Pushed by sitter into branch 'master'.

port to ECMQtDeclareLoggingCategory

this is more in line with other KDE software, albeit a bit noisy in our
case since we have so many categories.

the change also implicitly pushes the default logging from debug level
to info level, reducing the unnecessary logging noise generated by the
portals

M  +1    -0    CMakeLists.txt
M  +97   -0    src/CMakeLists.txt
M  +1    -3    src/access.cpp
M  +2    -4    src/accessdialog.cpp
M  +1    -4    src/account.cpp
M  +1    -4    src/appchooser.cpp
M  +1    -3    src/background.cpp
M  +1    -4    src/desktopportal.cpp
M  +1    -3    src/dynamiclauncher.cpp
M  +1    -2    src/dynamiclauncherdialog.cpp
M  +1    -3    src/email.cpp
M  +1    -3    src/filechooser.cpp
M  +1    -3    src/inhibit.cpp
M  +5    -0    src/kirigami-filepicker/CMakeLists.txt
M  +1    -3    src/kirigami-filepicker/api/mobilefiledialog.cpp
M  +1    -3    src/notification.cpp
M  +1    -3    src/notificationinhibition.cpp
M  +1    -3    src/print.cpp
M  +1    -4    src/remotedesktop.cpp
M  +2    -4    src/remotedesktopdialog.cpp
M  +1    -3    src/request.cpp
M  +1    -3    src/screencast.cpp
M  +1    -3    src/screenshot.cpp
M  +1    -3    src/screenshotdialog.cpp
M  +1    -3    src/session.cpp
M  +1    -3    src/settings.cpp
M  +1    -3    src/waylandintegration.cpp
M  +1    -3    src/xdg-desktop-portal-kde.cpp

https://invent.kde.org/plasma/xdg-desktop-portal-kde/commit/fe4d331e85468e67ce07fb3facb51fe04545cd57