Summary: | A brush preset made with the 5.2.0-prealpha causes a crash in 5.0.6 | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Ahab Greybeard <ahab.greybeard> |
Component: | Brush engines | Assignee: | Tiar <tamtamy.tymona> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | halla, maoaibks, noctis.crawler, rabeson.franck, tamtamy.tymona, tgdev001, tomtomtomreportingin |
Priority: | NOR | Keywords: | regression, release_blocker |
Version: | nightly build (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Debian stable | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Simple renamed brush preset |
Description
Ahab Greybeard
2022-06-18 10:20:35 UTC
I created another brush in 5.1.0 and this one crashes in 5.0.6 Note: https://invent.kde.org/graphics/krita/-/commit/74eb1ffa9cafc529585e7a47bf5c84f0ec4d0bf7 might be the breaking commit. Fixed by reverting mentioned commit: https://invent.kde.org/graphics/krita/-/commit/9e12726bf39cf1053755fc7fbf35ba39a32e7ed1 . I reopened the bug that was fixed in that commit: bug 446376 *** Bug 456484 has been marked as a duplicate of this bug. *** For reference, to continue using brushes from 5.1 beta 1 in other versions, use this plugin: https://krita-artists.org/t/brush-fixer-for-brushes-created-in-krita-5-1-beta-1/44075 *** Bug 456834 has been marked as a duplicate of this bug. *** *** Bug 456775 has been marked as a duplicate of this bug. *** Git commit f409ceb9faf236d302a13d5866aae3907bc5e036 by Dmitry Kazakov, on behalf of Agata Cacko. Committed on 15/08/2022 at 10:55. Pushed by dkazakov into branch 'krita/5.1'. Fix crash on incorrect brush preset metadata Before this commit, if you tried to open a brush preset that had incorrect brush metadata (for example any brush saved in Krita 5.1 beta 1, with < changed to < etc.), Krita would crash. This commit ensures it will not crash in that case. It's not an ideal solution, because there is no way to propagate the information about the issue and the safe assert around line 370 in KisBrushBasedPaintOpSettings::regenerateResourceCache() would still be fired. However it's less disruptive for the user. M +6 -0 plugins/paintops/libpaintop/kis_brush_based_paintop_settings.cpp https://invent.kde.org/graphics/krita/commit/f409ceb9faf236d302a13d5866aae3907bc5e036 Git commit 78cca8fbaea96ac37687b8d8ef2c94d8eedb46cd by Dmitry Kazakov, on behalf of Agata Cacko. Committed on 15/08/2022 at 10:55. Pushed by dkazakov into branch 'master'. Fix crash on incorrect brush preset metadata Before this commit, if you tried to open a brush preset that had incorrect brush metadata (for example any brush saved in Krita 5.1 beta 1, with < changed to < etc.), Krita would crash. This commit ensures it will not crash in that case. It's not an ideal solution, because there is no way to propagate the information about the issue and the safe assert around line 370 in KisBrushBasedPaintOpSettings::regenerateResourceCache() would still be fired. However it's less disruptive for the user. M +6 -0 plugins/paintops/libpaintop/kis_brush_based_paintop_settings.cpp https://invent.kde.org/graphics/krita/commit/78cca8fbaea96ac37687b8d8ef2c94d8eedb46cd |