| Summary: | Option to keep floating panels -floating- when windows are maximized and using "Maximized Window Gap" Kwin Script | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Damian C <dcalvino> |
| Component: | Panel | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | nate, niccolo.venerandi, raninepaths |
| Priority: | NOR | ||
| Version First Reported In: | 5.25.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=455323 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/ed0214057e7ae78bedc4486a6344db9459ce5570 | Version Fixed In: | 5.27 |
| Sentry Crash Report: | |||
| Attachments: | example of the "desired" result but with a non maximized window | ||
|
Description
Damian C
2022-06-18 10:01:46 UTC
This is one option that would also resolve Bug 455323. I would like to state that I also second this request. It would be helpful if there was a option for floating panel to be always floating, instead of becoming like normal panel when window is maximized regardless whether Kwin Script "Maximized Window Gap" is used. This really is a downstream issue. I think it's fair on our side to consider that a maximized window will touch the screen borders. The fact that a third party kwin script forces the maximized window to be floating even when maximized produces not only this bug, but other ones too, due to the same assumption (as an example, you loose the window shadow and rounded corners). I think in this case it's the script which is taking a risky approach. This wouldn't fix 455323 either. That bug refers to the fact that, when a window is maximized, there's too much margin around the panel. Adding an option to not de-float the panel at all wouldn't fix that: most people wouldn't discover the option and be left with the bigger margins by default, and people that want less margin would have to disable de-floating entirely. In the (near) future, I would like the de-floating mechanism to be a bit smarter, and defloat in other cases too, such as when you have two windows side by side that occupy all the screen. This could be approached in various ways, as an example the panel could de-float it there's any window that's directly touching it. This would (indirectly) fix this bug and alleviate 455323 too (half of the de-floated margin was added due to the lack of this mechanism). Git commit ed0214057e7ae78bedc4486a6344db9459ce5570 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 25/10/2022 at 14:52. Pushed by ngraham into branch 'master'. Panel: when floating, de-float when window touches it A floating Panel now de-floats and becomes opaque whenever a window touches it. This also allows for a thinner Panel when a window is maximized (a normal Panel is 44 px; before this patch a de-floated one was 60, now it's 52px) and that should allay complaints about excessive margins). Related: bug 455483, bug 455323 FIXED-IN: 5.27 M +29 -6 desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/commit/ed0214057e7ae78bedc4486a6344db9459ce5570 (In reply to Nate Graham from comment #4) > Git commit ed0214057e7ae78bedc4486a6344db9459ce5570 by Nate Graham, on > behalf of Niccolò Venerandi. > Committed on 25/10/2022 at 14:52. > Pushed by ngraham into branch 'master'. > > Panel: when floating, de-float when window touches it > > A floating Panel now de-floats and becomes opaque whenever a window touches > it. > This also allows for a thinner Panel when a window is maximized (a normal > Panel > is 44 px; before this patch a de-floated one was 60, now it's 52px) and that > should > allay complaints about excessive margins). > Related: bug 455483, bug 455323 > FIXED-IN: 5.27 > > M +29 -6 desktoppackage/contents/views/Panel.qml > > https://invent.kde.org/plasma/plasma-desktop/commit/ > ed0214057e7ae78bedc4486a6344db9459ce5570 Thank you! looking forward to 5.27 |