| Summary: | Recorder "Clean up Recordings" button title doesn't make any sense | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Dmitrii Utkin <loentar> |
| Component: | Dockers/Recorder | Assignee: | wolthera <griffinvalley> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | halla |
| Priority: | NOR | ||
| Version: | 5.0.6 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/337b9a77af66e536d11aadf2bbe3f734ec1a13d1 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Dmitrii Utkin
2022-06-13 10:01:10 UTC
Wolthera, can you take a look? Git commit e1deda8a9d1017cafdff4aa832ff5d6357a99024 by Dmitry Kazakov. Committed on 08/11/2024 at 11:41. Pushed by dkazakov into branch 'master'. [string freeze exception] Recover "Clean Up" button in the Recordings Manager When the manager was refactored into supporting QDialogButtonBox, then clean-up button was replaced with a "Discard" button. Even though it sounds sensible in English, it has a different meaning in QDialogButtonBox and, therefore, in translations. In translations, the button is usually translated as "Close without saving", which is not what the button actually does in Krita. M +5 -3 plugins/dockers/recorder/recorder_snapshots_manager.cpp M +1 -0 plugins/dockers/recorder/recorder_snapshots_manager.h M +1 -1 plugins/dockers/recorder/recorder_snapshots_manager.ui https://invent.kde.org/graphics/krita/-/commit/e1deda8a9d1017cafdff4aa832ff5d6357a99024 Git commit 337b9a77af66e536d11aadf2bbe3f734ec1a13d1 by Dmitry Kazakov. Committed on 08/11/2024 at 11:43. Pushed by dkazakov into branch 'krita/5.2'. [string freeze exception] Recover "Clean Up" button in the Krita's Recordings Manager When the manager was refactored into supporting QDialogButtonBox, then clean-up button was replaced with a "Discard" button. Even though it sounds sensible in English, it has a different meaning in QDialogButtonBox and, therefore, in translations. In translations, the button is usually translated as "Close without saving", which is not what the button actually does in Krita. CC:kde-i18n-doc@kde.org CC:kimageshop@kde.org M +5 -3 plugins/dockers/recorder/recorder_snapshots_manager.cpp M +1 -0 plugins/dockers/recorder/recorder_snapshots_manager.h M +1 -1 plugins/dockers/recorder/recorder_snapshots_manager.ui https://invent.kde.org/graphics/krita/-/commit/337b9a77af66e536d11aadf2bbe3f734ec1a13d1 |