Bug 455189

Summary:	Icons-only buttons don't become text-only buttons when telling the system to show text instead of icons on buttons
Product:	[Frameworks and Libraries] frameworks-qqc2-desktop-style	Reporter:	Roke Julian Lockhart Beedell <4wy78uwh>
Component:	general	Assignee:	Marco Martin <notmart>
Status:	RESOLVED FIXED
Severity:	minor	CC:	ahiemstra, kde, kdelibs-bugs-null, mail, nate, noahadvs, uhhadd
Priority:	NOR	Keywords:	accessibility
Version First Reported In:	5.96.0
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=455194
Latest Commit:		Version Fixed/Implemented In:	6.0
Sentry Crash Report:
Attachments:	Inadherent "List view". Inadherent "Icon view".

Description Roke Julian Lockhart Beedell 2022-06-12 20:26:30 UTC

SUMMARY:
Observe the previous title or the subsequent observed consequence.

STEPS TO REPRODUCE:
1. Configure all labels to be text via “kcmshell5 kcm_style”.
2. Invoke the relevant window.

OBSERVED RESULT:
Iconography is presented by the relevant window although I have configured plasma-systemsettings to mandate textual labels.

EXPECTED RESULT:
Buttons should be represented by what I have configured within plasma-systemsettings, which for me is solely text, so no iconography should be present within the window. (The sole exception is probably the iconography that represents the files and folders, because Dolphin retains them.)

SOFTWARE/OS VERSIONS:
Windows: Negative.
macOS: Negative.
Linux/KDE Plasma: Positive.
KDE Plasma Version: “5.25.0”.
KDE Frameworks Version: “5.94.0”.
Qt Version: “5.15.4”.

ADDITIONAL INFORMATION:
This has already been remediated within the Places panel, as “http://bugs.kde.org/show_bug.cgi?id=445744” demonstrates.

Comment 1 Roke Julian Lockhart Beedell 2022-07-21 12:02:04 UTC

Created attachment 150787 [details]
Inadherent "List view".

Comment 2 Roke Julian Lockhart Beedell 2022-07-21 12:02:38 UTC

Created attachment 150788 [details]
Inadherent "Icon view".

Comment 3 Roke Julian Lockhart Beedell 2022-07-21 22:45:35 UTC

Comment on attachment 150788 [details]
Inadherent "Icon view".

I apologize: this is not adherent to the preference. I was thinking of a different issue, whereby the sizes of the iconography is inconsistent, whereas this problem is lack of adherence to replacement of the iconography with text when configured.

Comment 4 Roke Julian Lockhart Beedell 2022-07-21 22:46:33 UTC

Comment on attachment 150788 [details]
Inadherent "Icon view".

The iconography remains present.

Comment 5 Nate Graham 2022-07-21 22:47:16 UTC

No need to add more comments or attachments; the issue is understood.

Comment 6 Nate Graham 2024-02-13 16:53:47 UTC

In progress with https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/367.

Comment 7 Nate Graham 2024-02-14 16:21:50 UTC

Git commit 4b6ea80efcdba8423761c1da8ae0796fcdbd55bb by Nate Graham, on behalf of Evgeny Chesnokov.
Committed on 14/02/2024 at 16:21.
Pushed by ngraham into branch 'master'.

DialogButtonBox: Respect QStyle::SH_DialogButtonBox_ButtonsHaveIcons

This way, if the style asks for no icons in DialogButtonBoxes, apps
themed with qqc2-desktop-style will oblige.

M  +10   -0    org.kde.desktop/DialogButtonBox.qml
M  +2    -0    plugin/kquickstyleitem.cpp

https://invent.kde.org/frameworks/qqc2-desktop-style/-/commit/4b6ea80efcdba8423761c1da8ae0796fcdbd55bb

Comment 8 Nate Graham 2024-02-16 15:43:08 UTC

This is fixed in KF6.

Comment 9 Roke Julian Lockhart Beedell 2024-02-16 22:52:26 UTC Comment hidden (spam)

(In reply to Nate Graham from comment #8)
> This is fixed in KF6.

Surely, per https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/367#note_871639 and https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/367#note_870785, this is not remediated?

Comment 10 Roke Julian Lockhart Beedell 2024-02-16 22:53:03 UTC Comment hidden (spam)

(In reply to `{third: "Beedell", first: "Roke"}`{.JSON5} from comment #9)
> (In reply to Nate Graham from comment #8)
> > This is fixed in KF6.
> 
> Surely, per
> https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/
> 367#note_871639 and
> https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/
> 367#note_870785, this is not remediated?

Ah — https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/367#note_872508.