Summary: | Icons-only buttons don't become text-only buttons when telling the system to show text instead of icons on buttons | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-qqc2-desktop-style | Reporter: | Roke Julian Lockhart Beedell <4wy78uwh> |
Component: | general | Assignee: | Marco Martin <notmart> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | ahiemstra, kde, kdelibs-bugs, mail, nate, noahadvs, uhhadd |
Priority: | NOR | Keywords: | accessibility |
Version: | 5.96.0 | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 6.0 | |
Attachments: |
Inadherent "List view".
Inadherent "Icon view". |
Description
Roke Julian Lockhart Beedell
2022-06-12 20:26:30 UTC
Created attachment 150787 [details]
Inadherent "List view".
Created attachment 150788 [details]
Inadherent "Icon view".
Comment on attachment 150788 [details]
Inadherent "Icon view".
I apologize: this is not adherent to the preference. I was thinking of a different issue, whereby the sizes of the iconography is inconsistent, whereas this problem is lack of adherence to replacement of the iconography with text when configured.
Comment on attachment 150788 [details]
Inadherent "Icon view".
The iconography remains present.
No need to add more comments or attachments; the issue is understood. Git commit 4b6ea80efcdba8423761c1da8ae0796fcdbd55bb by Nate Graham, on behalf of Evgeny Chesnokov. Committed on 14/02/2024 at 16:21. Pushed by ngraham into branch 'master'. DialogButtonBox: Respect QStyle::SH_DialogButtonBox_ButtonsHaveIcons This way, if the style asks for no icons in DialogButtonBoxes, apps themed with qqc2-desktop-style will oblige. M +10 -0 org.kde.desktop/DialogButtonBox.qml M +2 -0 plugin/kquickstyleitem.cpp https://invent.kde.org/frameworks/qqc2-desktop-style/-/commit/4b6ea80efcdba8423761c1da8ae0796fcdbd55bb This is fixed in KF6. (In reply to Nate Graham from comment #8) > This is fixed in KF6. Surely, per https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/367#note_871639 and https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/367#note_870785, this is not remediated? (In reply to `{third: "Beedell", first: "Roke"}`{.JSON5} from comment #9) > (In reply to Nate Graham from comment #8) > > This is fixed in KF6. > > Surely, per > https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/ > 367#note_871639 and > https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/ > 367#note_870785, this is not remediated? Ah — https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/367#note_872508. |