Bug 455174

Summary: When the Android version disables "HI-DPI support", the width of the new file window is too small.
Product: [Applications] krita Reporter: Eranthis stellata Maxim <1012468643>
Component: UsabilityAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED INTENTIONAL    
Severity: normal CC: alvin
Priority: NOR    
Version First Reported In: 5.0.6   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: A comparison of enabling HI-DPI support and disabling HI-DPI support.

Description Eranthis stellata Maxim 2022-06-12 05:30:17 UTC 
Created attachment 149635 [details]
A comparison of enabling HI-DPI support and disabling HI-DPI support.

SUMMARY
When the Android version disables "HI-DPI support", the width of the new file window is too small.
Because the window width is too small, the text is crowded together.


STEPS TO REPRODUCE
1. Disable "HI-DPI" support.
2. Restart krita.
3. Create a new file.
4. Observe the New File window.

OBSERVED RESULT
The new file window scale remains the same, it just looks smaller.

EXPECTED RESULT
The proportion of the new window has changed, and the width has become very small.

SOFTWARE/OS VERSIONS
Krita

 Version: 5.0.6
 Languages: zh_Hans_CN, zh
 Hidpi: false

Qt

  Version (compiled): 5.12.12
  Version (loaded): 5.12.12

OS Information

  Build ABI: arm64-little_endian-lp64
  Build CPU: arm64
  CPU: arm64
  Kernel Type: linux
  Kernel Version: 5.4.86-qgki-23595105-abT733XXU1BVE3
  Pretty Productname: Android  (12.0)
  Product Type: android
  Product Version: 12.0
  Desktop: 

OpenGL Info
 
  Vendor:  "Qualcomm" 
  Renderer:  "Adreno (TM) 642L" 
  Version:  "OpenGL ES 3.2 V@0530.0 (GIT@009e9bf746, I4cc83cbab4, 1623344793) (Date:06/10/21)" 
  Shading language:  "OpenGL ES GLSL ES 3.20" 
  Requested format:  QSurfaceFormat(version 2.0, options QFlags<QSurfaceFormat::FormatOption>(), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::NoProfile) 
  Current format:  QSurfaceFormat(version 3.2, options QFlags<QSurfaceFormat::FormatOption>(), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples 0, swapBehavior QSurfaceFormat::DefaultSwapBehavior, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::NoProfile) 
     Version: 3.2
     Supports deprecated functions false 
     is OpenGL ES: true 
  supportsBufferMapping: true 
  supportsBufferInvalidation: false 
  Extensions: 
     "GL_OES_surfaceless_context" 
     "GL_EXT_texture_filter_anisotropic" 
     "GL_KHR_no_error" 
     "GL_QCOM_texture_foveated_subsampled_layout" 
     "GL_QCOM_validate_shader_binary" 
     "GL_EXT_shader_non_constant_global_initializers" 
     "GL_EXT_protected_textures" 
     "GL_EXT_multisampled_render_to_texture2" 
     "GL_OES_EGL_image_external_essl3" 
     "GL_KHR_debug" 
     "GL_OES_framebuffer_object" 
     "GL_EXT_multisampled_render_to_texture" 
     "GL_OES_texture_storage_multisample_2d_array" 
     "GL_EXT_color_buffer_float" 
     "GL_EXT_debug_label" 
     "GL_EXT_blend_func_extended" 
     "GL_EXT_EGL_image_external_wrap_modes" 
     "GL_EXT_EGL_image_array" 
     "GL_OES_depth_texture" 
     "GL_OES_texture_float_linear" 
     "GL_EXT_debug_marker" 
     "GL_OES_depth24" 
     "GL_EXT_gpu_shader5" 
     "GL_KHR_texture_compression_astc_hdr" 
     "GL_EXT_clip_control" 
     "GL_EXT_texture_type_2_10_10_10_REV" 
     "GL_OVR_multiview_multisampled_render_to_texture" 
     "GL_EXT_texture_sRGB_R8" 
     "GL_OES_packed_depth_stencil" 
     "GL_EXT_blit_framebuffer_params" 
     "GL_OES_texture_float" 
     "GL_EXT_fragment_invocation_density" 
     "GL_EXT_shader_io_blocks" 
     "GL_EXT_texture_sRGB_decode" 
     "GL_OES_texture_3D" 
     "GL_OES_sample_shading" 
     "GL_EXT_discard_framebuffer" 
     "GL_OES_texture_npot" 
     "GL_EXT_texture_buffer" 
     "GL_ARM_shader_framebuffer_fetch_depth_stencil" 
     "GL_KHR_blend_equation_advanced_coherent" 
     "GL_EXT_texture_border_clamp" 
     "GL_EXT_primitive_bounding_box" 
     "GL_OES_texture_half_float" 
     "GL_EXT_shader_framebuffer_fetch" 
     "GL_OES_rgb8_rgba8" 
     "GL_OES_texture_half_float_linear" 
     "GL_KHR_robust_buffer_access_behavior" 
     "GL_QCOM_shader_framebuffer_fetch_noncoherent" 
     "GL_EXT_geometry_shader" 
     "GL_OES_texture_stencil8" 
     "GL_KHR_texture_compression_astc_ldr" 
     "GL_EXT_draw_buffers_indexed" 
     "GL_OES_EGL_image_external" 
     "GL_OES_vertex_array_object" 
     "GL_QCOM_texture_foveated" 
     "GL_EXT_sRGB_write_control" 
     "GL_EXT_EGL_image_storage" 
     "GL_EXT_buffer_storage" 
     "GL_OES_vertex_half_float" 
     "GL_EXT_sRGB" 
     "GL_OES_sample_variables" 
     "GL_EXT_texture_cube_map_array" 
     "GL_OES_texture_compression_astc" 
     "GL_EXT_copy_image" 
     "GL_QCOM_shader_framebuffer_fetch_rate" 
     "GL_KHR_blend_equation_advanced" 
     "GL_QCOM_motion_estimation" 
     "GL_EXT_texture_format_BGRA8888" 
     "GL_QCOM_shading_rate" 
     "GL_OES_shader_image_atomic" 
     "GL_NV_shader_noperspective_interpolation" 
     "GL_OES_element_index_uint" 
     "GL_EXT_robustness" 
     "GL_QCOM_alpha_test" 
     "GL_OES_standard_derivatives" 
     "GL_EXT_disjoint_timer_query" 
     "GL_OVR_multiview" 
     "GL_EXT_external_buffer" 
     "GL_AMD_compressed_ATC_texture" 
     "GL_OES_shader_multisample_interpolation" 
     "GL_OES_EGL_sync" 
     "GL_EXT_clip_cull_distance" 
     "GL_EXT_texture_format_sRGB_override" 
     "GL_EXT_texture_norm16" 
     "GL_OVR_multiview2" 
     "GL_OES_get_program_binary" 
     "GL_EXT_read_format_bgra" 
     "GL_QCOM_tiled_rendering" 
     "GL_EXT_memory_object_fd" 
     "" 
     "GL_OES_EGL_image" 
     "GL_ANDROID_extension_pack_es31a" 
     "GL_OES_compressed_ETC1_RGB8_texture" 
     "GL_EXT_YUV_target" 
     "GL_QCOM_YUV_texture_gather" 
     "GL_EXT_tessellation_shader" 
     "GL_OES_depth_texture_cube_map" 
     "GL_EXT_color_buffer_half_float" 
     "GL_EXT_memory_object" 
     "GL_OES_texture_view" 

QPA OpenGL Detection Info 
  supportsDesktopGL: false 
  supportsOpenGLES: true 
  isQtPreferOpenGLES: true 

useBufferInvalidation (config option): false


Hardware Information

  GPU Acceleration: angle
  Memory: 7344 Mb
  Number of Cores: 8
  Swap Location: /data/data/org.krita/files

Current Settings

  Current Swap Location: /data/data/org.krita/files
  Current Swap Location writable: true
  Undo Enabled: true
  Undo Stack Limit: 200
  Use OpenGL: true
  Use OpenGL Texture Buffer: true
  Disable Vector Optimizations: false
  Disable AVX Optimizations: false
  Canvas State: OPENGL_SUCCESS
  Autosave Interval: 420
  Use Backup Files: true
  Number of Backups Kept: 1
  Backup File Suffix: ~
  Backup Location: Same Folder as the File
  Backup Location writable: false
  Use Win8 Pointer Input: false
  Use RightMiddleTabletButton Workaround: false
  Levels of Detail Enabled: false
  Use Zip64: false


Display Information
Number of screens: 1
	Screen: 0
		Name: 
		Depth: 32
		Scale: 1
		Resolution in pixels: 2560x1600
		Manufacturer: 
		Model: 
		Refresh Rate: 60


---------------------
================================================================================
SESSION: 12 Jun 2022 13:09:37 +0800. Executing /data/app/~~E7mlV7u_FDUo_VXSDPxFOQ==/org.krita-1g-zF3PaHd_KEElxEf7enQ==/lib/arm64/libkrita.so

Krita Version: 5.0.6, Qt version compiled: 5.12.12, loaded: 5.12.12. Process ID: 8056
-- -- -- -- -- -- -- --
12 Jun 2022 13:09:37 +0800: Style: fusion. Available styles: android, Windows, Fusion
12 Jun 2022 13:09:38 +0800: Creating database from scratch (database didn't exist, new schema version: 0.0.16).
12 Jun 2022 13:10:02 +0800: Created image "未命名", 2480 * 3508 pixels, 300 dpi. Color model: 8 位整数/通道 RGB/透明度 (sRGB-elle-V2-srgbtrc.icc). Layers: 2
12 Jun 2022 13:10:26 +0800: CLOSING SESSION
================================================================================
SESSION: 12 Jun 2022 13:10:27 +0800. Executing /data/app/~~E7mlV7u_FDUo_VXSDPxFOQ==/org.krita-1g-zF3PaHd_KEElxEf7enQ==/lib/arm64/libkrita.so

Krita Version: 5.0.6, Qt version compiled: 5.12.12, loaded: 5.12.12. Process ID: 8234
-- -- -- -- -- -- -- --
12 Jun 2022 13:10:27 +0800: Style: fusion. Available styles: android, Windows, Fusion
12 Jun 2022 13:10:28 +0800: Database is up to date. Version: 0.0.16, created by Krita 5.0.6, at 周日 6月 12 13:09:38 2022
12 Jun 2022 13:11:46 +0800: Created image "Unnamed", 2480 * 3508 pixels, 300 dpi. Color model: 8-bit integer/channel RGB/Alpha (sRGB-elle-V2-srgbtrc.icc). Layers: 2
12 Jun 2022 13:12:08 +0800: CLOSING SESSION
================================================================================
SESSION: 12 Jun 2022 13:12:10 +0800. Executing /data/app/~~E7mlV7u_FDUo_VXSDPxFOQ==/org.krita-1g-zF3PaHd_KEElxEf7enQ==/lib/arm64/libkrita.so

Krita Version: 5.0.6, Qt version compiled: 5.12.12, loaded: 5.12.12. Process ID: 8357
-- -- -- -- -- -- -- --
12 Jun 2022 13:12:10 +0800: Style: fusion. Available styles: android, Windows, Fusion
12 Jun 2022 13:12:11 +0800: Database is up to date. Version: 0.0.16, created by Krita 5.0.6, at 周日 6月 12 13:09:38 2022

---------------------
Comment 1 Alvin Wong 2022-06-12 15:23:53 UTC 
That's exactly what disabling high-DPI does...
Comment 2 Eranthis stellata Maxim 2022-06-12 16:12:21 UTC 
(In reply to Alvin Wong from comment #1)
> That's exactly what disabling high-DPI does...

I don't think it's a bug that new windows shrink after disabling "HI-DPI support".

I think it is correct that the new file window is proportionally smaller after disabling "HI-DPI support".
After disabling "HI-DPI support", the new file window is not proportionally smaller, but the width is significantly reduced.
So I think it's a bug.
Comment 3 Alvin Wong 2022-06-13 08:29:17 UTC 
This _is_ exactly what is expected from Qt's layout engine. The dialog width is normally restricted by an explicitly set minimum width, while the height is stretched by the individual widgets. When you disable high-DPI on a system with a large scale factor, the legacy font scaling stretches the height of the widgets resulting in this appearance to ensure the widgets are visible. The layout is just doing its job.
Comment 4 Eranthis stellata Maxim 2022-06-13 08:37:16 UTC 
(In reply to Alvin Wong from comment #3)
> This _is_ exactly what is expected from Qt's layout engine. The dialog width
> is normally restricted by an explicitly set minimum width, while the height
> is stretched by the individual widgets. When you disable high-DPI on a
> system with a large scale factor, the legacy font scaling stretches the
> height of the widgets resulting in this appearance to ensure the widgets are
> visible. The layout is just doing its job.

Thanks, now I know.