Summary: | Global shortcut launches terminal application without a terminal | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kglobalaccel | Reporter: | Jin Liu <ad.liu.jin> |
Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | a.samirh78, nate |
Priority: | NOR | ||
Version: | 5.94.0 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/kglobalaccel/commit/b72930eb075a79ff89e8db221749de978706e5bf | Version Fixed In: | 5.95 |
Description
Jin Liu
2022-06-10 09:58:14 UTC
BTW, the "Error opening terminal: unknown" message is printed by htop, when run without a terminal. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kglobalaccel/-/merge_requests/47 Wrong tab, sorry. Git commit b72930eb075a79ff89e8db221749de978706e5bf by Ahmad Samir, on behalf of Jin Liu. Committed on 02/07/2022 at 12:26. Pushed by ahmadsamir into branch 'master'. Launch app in terminal when Terminal=true When the desktop file has Terminal=true (e.g. htop), it should be launched in a terminal. Instead of calling "kstart5 -- <exec path>", this calls "kstart5 --application <desktop file name>" when and only when: 1. kstart5 is available 2. the desktop file is in XDG_DATA_HOME/applications/, not XDG_DATA_HOME/kglobalaccel/ 3. we are launching the desktop file's main group, not other actions M +35 -16 src/runtime/kserviceactioncomponent.cpp M +3 -0 src/runtime/kserviceactioncomponent.h https://invent.kde.org/frameworks/kglobalaccel/commit/b72930eb075a79ff89e8db221749de978706e5bf |