Bug 455067

Summary:	Low contrast with the Breeze-dark theme when updates are available
Product:	[Applications] Discover	Reporter:	Hari Rana (TheEvilSkeleton) <theevilskeleton>
Component:	discover	Assignee:	Dan Leinir Turthra Jensen <leinir>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	aleixpol, nate
Priority:	NOR	Keywords:	usability
Version First Reported In:	5.24.5
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/discover/commit/12d459441adaec46811faa2904fbf10c2b05d97d	Version Fixed/Implemented In:	5.27
Sentry Crash Report:
Attachments:	Update button with White text on bright orange

Description Hari Rana (TheEvilSkeleton) 2022-06-09 04:45:12 UTC

Created attachment 149572 [details]
Update button with White text on bright orange

SUMMARY
There is low contrast when updates are available in Discover.

STEPS TO REPRODUCE
1. Downgrade any program or wait to receive an update
2. Refresh
3. Open another tab to view the white text on orange scheme

OBSERVED RESULT
The white text on the bright orange makes it very difficult to read. Furthermore, when hovering over the "Update" button, the background color changes, but remains difficult to read.

EXPECTED RESULT
The use of darker colors as the background, making it readable.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
According to the [Contrast](https://flathub.org/apps/details/org.gnome.design.Contrast) app, The contrast ratio of the bright orange button with white text is 1.9:1, which is not legible.

When hovering, the contrast ratio is 2.4:1, which is still not legible.

Comment 1 Hari Rana (TheEvilSkeleton) 2022-06-09 04:48:25 UTC

My apologies. I forgot to fully fill up the form:

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux (VM using GNOME Boxes)
(available in About System)
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.4

Comment 2 Nate Graham 2022-06-10 17:00:11 UTC

Can confirm. I wonder if this is how we want to present updates in the first place. That bright orange background is pretty ugly and intrusive IMO. We already notify users about updates using a system notification and also a tray icon. Maybe it's overkill to do this too.

Comment 3 Bug Janitor Service 2022-06-10 17:15:17 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/316

Comment 4 Hari Rana (TheEvilSkeleton) 2022-06-10 17:20:09 UTC

(In reply to Bug Janitor Service from comment #3)
> A possibly relevant merge request was started @
> https://invent.kde.org/plasma/discover/-/merge_requests/316

Looks really good. I like it a lot.

Comment 5 Nate Graham 2022-12-27 15:45:56 UTC

Git commit 12d459441adaec46811faa2904fbf10c2b05d97d by Nate Graham.
Committed on 27/12/2022 at 15:38.
Pushed by ngraham into branch 'master'.

Refine how the "Updates" list item gets users' attention

Right now it uses a colored background which is a bit visually
unrefined, and also yields subpar text contrast with certain color
schemes.

This commit replaces that with a little badge emblem on the right side,
which looks better and eliminates all possible text readability issues.
FIXED-IN: 5.27

M  +6    -1    discover/qml/DiscoverDrawer.qml

https://invent.kde.org/plasma/discover/commit/12d459441adaec46811faa2904fbf10c2b05d97d