Bug 455054

Summary:	5.1 alpha installer for Windows has missing file associations
Product:	[Applications] krita	Reporter:	amyspark <amy>
Component:	* Unknown	Assignee:	Alvin Wong <alvin>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alvin
Priority:	NOR
Version First Reported In:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Compiled Sources
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/graphics/krita/commit/54f3ab8fc57fc93375b2e6b0d9a49f03d1a4efe6	Version Fixed/Implemented In:
Sentry Crash Report:

Description amyspark 2022-06-08 22:42:23 UTC

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

Not sure if the bug belongs here or on Alvin's repo, but:

I've found that the installer's shell extension doesn't associate Krita with the following impex plugins:

- JPEG2000
- TGA
- JPEG XL
- RAW

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
commit 5871395515

Comment 1 Alvin Wong 2022-06-09 08:15:08 UTC

For the NSIS installer they are in the installer itself. This is the last time I updated the list: https://github.com/alvinhochun/KritaShellExtension/commit/ae4c5a83ac16cf7ff4743954661694d32d13d5ad

Then, for the MSIX package it is separately defined in the manifest: https://invent.kde.org/graphics/krita/-/commit/5e7b12aa1e96f0e621a188ae6a49d5e413db2c2a

I will add .jxl to the list some time because it's new, but not having the other three file types was kind of a deliberate choice...

Comment 2 Bug Janitor Service 2022-06-15 09:16:45 UTC

A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1475

Comment 3 Alvin Wong 2022-06-18 08:37:55 UTC

Git commit 10b89f37458d939f574099e694e759b4e192e8cb by Alvin Wong.
Committed on 18/06/2022 at 08:36.
Pushed by alvinwong into branch 'master'.

win: Update shell extension to v1.2.4d

Updated to add file association for jxl.

M  +3    -3    packaging/windows/installer/MakeInstallerNsis.cmake.in [INFRASTRUCTURE]

https://invent.kde.org/graphics/krita/commit/10b89f37458d939f574099e694e759b4e192e8cb

Comment 4 Alvin Wong 2022-06-18 08:38:03 UTC

Git commit 6449db65a49f95ce8c7860ab707ed3bcb31d5ff2 by Alvin Wong.
Committed on 18/06/2022 at 08:36.
Pushed by alvinwong into branch 'master'.

win: Add .jxl association for MSIX

M  +1    -0    packaging/windows/msix/manifest.xml.in

https://invent.kde.org/graphics/krita/commit/6449db65a49f95ce8c7860ab707ed3bcb31d5ff2

Comment 5 Alvin Wong 2022-06-18 08:39:08 UTC

Git commit e60f6c9415ff7ad5509b2905bdf1ba2bf5533d23 by Alvin Wong.
Committed on 18/06/2022 at 08:38.
Pushed by alvinwong into branch 'krita/5.1'.

win: Add .jxl association for MSIX
(cherry picked from commit 6449db65a49f95ce8c7860ab707ed3bcb31d5ff2)

M  +1    -0    packaging/windows/msix/manifest.xml.in

https://invent.kde.org/graphics/krita/commit/e60f6c9415ff7ad5509b2905bdf1ba2bf5533d23

Comment 6 Alvin Wong 2022-06-18 08:39:16 UTC

Git commit 54f3ab8fc57fc93375b2e6b0d9a49f03d1a4efe6 by Alvin Wong.
Committed on 18/06/2022 at 08:38.
Pushed by alvinwong into branch 'krita/5.1'.

win: Update shell extension to v1.2.4d

Updated to add file association for jxl.
(cherry picked from commit 10b89f37458d939f574099e694e759b4e192e8cb)

M  +3    -3    packaging/windows/installer/MakeInstallerNsis.cmake.in [INFRASTRUCTURE]

https://invent.kde.org/graphics/krita/commit/54f3ab8fc57fc93375b2e6b0d9a49f03d1a4efe6