Bug 454912

Summary:	CMake build: "Optional" packages are actually required
Product:	[Frameworks and Libraries] layer-shell-qt	Reporter:	A. Wilcox (awilfox) <awilfox>
Component:	general	Assignee:	Aleix Pol <aleixpol>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/layer-shell-qt/commit/9573abb542a95f2566e61dba38b174a1d658cfbc	Version Fixed In:	5.24.6
Sentry Crash Report:

Description A. Wilcox (awilfox) 2022-06-05 23:17:21 UTC

SUMMARY
The dependencies in layer-shell-qt's CMake file are all required, yet they are marked as optional.


STEPS TO REPRODUCE
1. Build with required packages installed but optional packages not installed.


OBSERVED RESULT
Without wayland-protocols:
make[2]: *** No rule to make target '/stable/xdg-shell/xdg-shell.xml', needed by 'src/wayland-xdg-shell-client-protocol.h'.  Stop.

Without QtWaylandScanner:
/bin/sh: 1: QtWaylandScanner_EXECUTABLE-NOTFOUND: not found
make[2]: *** [src/CMakeFiles/LayerShellQtInterface.dir/build.make:106: src/qwayland-wlr-layer-shell-unstable-v1.h] Error 127


EXPECTED RESULT
Either the build should succeed, or the packages should be listed as REQUIRED instead of OPTIONAL in CMakeLists.txt.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Linux gwyn.foxkit.us 5.15.28-mc1-easy #1 SMP Sat Apr 30 09:14:06 UTC 2022 ppc64 GNU/Linux
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.4 + KDE patches


ADDITIONAL INFORMATION
n/a

Comment 1 Bug Janitor Service 2022-06-06 10:26:29 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/layer-shell-qt/-/merge_requests/18

Comment 2 Nicolas Fella 2022-06-06 10:39:21 UTC

Git commit 34e7c90c2d544dbf88a937a0d52a4c54e0220f67 by Nicolas Fella.
Committed on 06/06/2022 at 10:26.
Pushed by nicolasfella into branch 'master'.

Mark required deps as required

M  +3    -3    CMakeLists.txt

https://invent.kde.org/plasma/layer-shell-qt/commit/34e7c90c2d544dbf88a937a0d52a4c54e0220f67

Comment 3 Nicolas Fella 2022-06-06 10:40:46 UTC

Git commit 7f555ba9bd4801da1c1df9a40b0c1133b23f3780 by Nicolas Fella.
Committed on 06/06/2022 at 10:40.
Pushed by nicolasfella into branch 'Plasma/5.24'.

Mark required deps as required
(cherry picked from commit 34e7c90c2d544dbf88a937a0d52a4c54e0220f67)

M  +3    -3    CMakeLists.txt

https://invent.kde.org/plasma/layer-shell-qt/commit/7f555ba9bd4801da1c1df9a40b0c1133b23f3780

Comment 4 Nicolas Fella 2022-06-06 10:41:10 UTC

Git commit 9573abb542a95f2566e61dba38b174a1d658cfbc by Nicolas Fella.
Committed on 06/06/2022 at 10:40.
Pushed by nicolasfella into branch 'Plasma/5.25'.

Mark required deps as required
(cherry picked from commit 34e7c90c2d544dbf88a937a0d52a4c54e0220f67)

M  +3    -3    CMakeLists.txt

https://invent.kde.org/plasma/layer-shell-qt/commit/9573abb542a95f2566e61dba38b174a1d658cfbc