Bug 454878

Summary:	Images being shown in full res in Compact mode
Product:	[Applications] NeoChat	Reporter:	Jan Bidler <janbidler00>
Component:	General	Assignee:	Tobias Fella <fella>
Status:	RESOLVED FIXED
Severity:	normal	CC:	carl, james.h.graham
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/network/neochat/commit/7aed6d2e44d176bd3aee3f523648b862e02a7e34	Version Fixed/Implemented In:
Sentry Crash Report:

Description Jan Bidler 2022-06-05 13:46:57 UTC

SUMMARY
Images are shown in their full resolution on compact mode, contrary to "Bubbles" mode.

STEPS TO REPRODUCE
1. Send a very large image in a room
2. Go to Settings -> Appearance -> and toggle to "Compact"0
3. Go view the image you sent earlier.

OBSERVED RESULT
The image will take a lot of space in the view, making it necessary to scroll a lot.

EXPECTED RESULT
The image should get resized to take less space.

SOFTWARE/OS VERSIONS
Windows: 10 21H1
NeoChat Version: 22.04
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.2

Comment 1 James Graham 2022-07-29 18:40:32 UTC

Can confirm this is due to the fact that the limiting factor on image size is the width of the bubble, which is still technically there in compact mode just invisible and set to maximise to the available width in the lisView. This means that if the listView is wide a large image will be able to grow to full size taking up a lot of space.

This could pretty easily be solved by putting a maximum size on the image we just have to pick what we think looks good.

Comment 2 Bug Janitor Service 2022-11-09 19:28:59 UTC

A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/593

Comment 3 James Graham 2022-11-10 18:49:59 UTC

Git commit 7aed6d2e44d176bd3aee3f523648b862e02a7e34 by James Graham.
Committed on 10/11/2022 at 18:49.
Pushed by nvrwhere into branch 'master'.

Apply max image size so they don't become huge in compact mode.

Set max size to gridUnits * 30. The aim is to allow them to be generally bigger than bubble mode but not so huge that they take up the entire screen

M  +4    -2    src/qml/Component/Timeline/ImageDelegate.qml

https://invent.kde.org/network/neochat/commit/7aed6d2e44d176bd3aee3f523648b862e02a7e34